[Android] Add support to TextInput for Image Keyboards

[stwiname]

Summary

Adds Image Keyboard Support to TextInput on Android. It adds the onImageInput prop which calls the callback and provides a local content uri, base64 encoded string of the image, mime type and possibly a url to the image on the web.

Changelog

[Android] [Added] - onImageInput prop to the TextInput component

Test Plan

Tested with Gboard, Fleksy and Tenor gif keyboard on android.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[jasonivers]

Is there any update on the status of this? It might not seem very important, but it IS a nice user enhancement, and the pull request is already here (although it appears it needs updated now). I'd really like to use this, without relying on patching things locally.

[stwiname]

@jasonivers, I've rebased so everything is up to date

I don't know what can be done to get someone to merge this

[roshangm1]

@cpojer @hramos This is a great PR to be merged if working properly. BTW, what are the ways we can test this locally ?

[stwiname]

@roshangm1 are you after example usage or how to run the react-native fork?
Either way here's a simple example

<TextInput
  onImageInput={(event) => {
    // Will log an object of type { uri: string, linkUri: string, data: string, mime: string}
    console.log(event.nativeEvent);
  }}
/>

Then using an image keyboard on android (Gboard, Fleksy, Tenor gif keyboard and probably a whole lot more) the function will get called.

On iOS the onImageInupt function will never be called

[jasonivers]

@jasonivers, I've rebased so everything is up to date

I don't know what can be done to get someone to merge this

There appear to be a couple of test failures. That could be why?

[stwiname]

@jasonivers, I've rebased so everything is up to date
I don't know what can be done to get someone to merge this

There appear to be a couple of test failures. That could be why?

Those tests seem to be failing on other PRs and unrelated to the changes

[jasonivers]

@JoshuaGross - I saw you merged a pull request for something to do with TextInput, and I have no idea how else to find the right person for this PR. Is there anything that needs done to get the right person's attention?

[Gustash]

Bump. This would be an awesome feature.

Also, unless I'm missing something, this PR doesn't seem to introduce this as optional? On some inputs you don't want this capability

[Gustash]

If anyone bumps into this while this PR isn't merged, I've created a package to not only handle this but also images copied to the clipboard on iOS.

https://www.npmjs.com/package/react-native-image-keyboard

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,761,499	2,077
android	hermes	armeabi-v7a	6,408,592	2,055
android	hermes	x86	7,142,969	2,065
android	hermes	x86_64	7,034,242	2,043
android	jsc	arm64-v8a	8,929,946	1,950
android	jsc	armeabi-v7a	8,569,438	1,967
android	jsc	x86	8,754,548	1,952
android	jsc	x86_64	9,331,468	1,963

Base commit: b000664

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	809,568	0

Base commit: b000664

[tsvetann]

a year and a half later...any luck here?

[KrisLau]

Would love to have this merged in as well

[TheMakerOleguch]

Any update on this?

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.