Add ReactFiberErrorDialog from React + tests #25671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Summary: Pull Request resolved: facebook#25671 Moves the RN-specific `ReactFiberErrorDialog` implementation from React to RN for easier iteration. Also adds new unit tests. This current change is additive, so we're compatible with the current React renderer which still uses `ExceptionsManager` and not the file added here. After the corresponding React update we can remove `ExceptionsManager` from the RN private interface entirely. Reviewed By: cpojer Differential Revision: D16278938 fbshipit-source-id: d2e44ada12f959b8d483a5ca1387c3891a10acbf
motiz88
force-pushed
the
export-D16278938
branch
from
43d71ad
to
e22e50a
Compare
|
This pull request was successfully merged by @motiz88 in a9cab21. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
Summary: #25671 added a shallow unit test for `ReactFiberErrorDialog`, mocking out the (JS) `ExceptionsManager` module. This rewrites that test in terms of `NativeExceptionsManager` instead, so the integration with `ExceptionsManager` is also tested. Also adds tests for the behaviour of the `framesToPop` and `jsEngine` extended error fields, and for passing a frozen error object (seeing as we potentially mutate the error). Reviewed By: rickhanlonii Differential Revision: D16330341 fbshipit-source-id: 0b514d1c8f193a114748739ec31ddb4e06e4d2fd
aleclarson
pushed a commit
to alloc/react-native-macos
that referenced
this pull request
Nov 3, 2019
Summary: Pull Request resolved: facebook/react-native#25671 Moves the RN-specific `ReactFiberErrorDialog` implementation from React to RN for easier iteration. Also adds new unit tests. This current change is additive, so we're compatible with the current React renderer which still uses `ExceptionsManager` and not the file added here. After the corresponding React update we can remove `ExceptionsManager` from the RN private interface entirely. Reviewed By: cpojer Differential Revision: D16278938 fbshipit-source-id: 0c2c0c3e65e524e079730ae3b0cc23e0c0bdc5fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the RN-specific
ReactFiberErrorDialogimplementation from React to RN for easier iteration. Also adds new unit tests.This current change is additive, so we're compatible with the current React renderer which still uses
ExceptionsManagerand not the file added here. After the corresponding React update we can removeExceptionsManagerfrom the RN private interface entirely.Differential Revision: D16278938