Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate iOS .xcodeproj #25583

Closed
wants to merge 3 commits into from
Closed

deprecate iOS .xcodeproj #25583

wants to merge 3 commits into from

Commits on Jul 11, 2019

  1. TM iOS: Run RCTPlatform methods on the main queue 

    Summary:
This module expects to compute main queue stuffs inside getConstants(), mark it so. This address crashes when running tests:

```
Main Thread Checker: UI API called on a background thread: -[UIApplication keyWindow]
PID: 88318, TID: 22602153, Thread name: com.facebook.react.JavaScript, Queue name: com.apple.root.default-qos.overcommit, QoS: 0
Backtrace:
4   RNTester                            0x0000000100beece8 RCTKeyWindow + 72
5   RNTester                            0x0000000100beeee4 RCTForceTouchAvailable + 148
6   RNTester                            0x0000000100c0b54d -[RCTPlatform getConstants] + 109
```

Differential Revision: D16198720

fbshipit-source-id: babab3d117b3049744468ab6633e653a8a2d69e6
    @fkgozali @facebook-github-bot
    fkgozali authored and facebook-github-bot committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    c68f08b View commit details
    Browse the repository at this point in the history

  2. iOS: suppress nullability completeness warning in TM generated spec file 

    Summary: For now, suppress this warning - they are harmless.

Differential Revision: D16198994

fbshipit-source-id: 33b68960b283f7d8b9121b690c0cbf9516fd93dc
    @fkgozali @facebook-github-bot
    fkgozali authored and facebook-github-bot committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    555e5e6 View commit details
    Browse the repository at this point in the history

  3. deprecate iOS .xcodeproj (facebook#25583) 

    Summary:
Pull Request resolved: facebook#25583

We now use CocoaPods for better maintainability.

Reviewed By: hramos

Differential Revision: D16193719

fbshipit-source-id: faf6c7920cf2b37754f78b419c26c377da6e58e2
    @fkgozali @facebook-github-bot
    fkgozali authored and facebook-github-bot committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    a8baf28 View commit details
    Browse the repository at this point in the history