Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate StatusBar #24860

Closed
wants to merge 1 commit into from
Closed

Undeprecate StatusBar #24860

wants to merge 1 commit into from

Conversation

cpojer
Copy link
Contributor

@cpojer cpojer commented May 15, 2019

Summary

There has been push back to remove this module from React Native. Since it is contentious, let's revert the deprecation and table this conversation until later.

Changelog

[General] [Changed] - Undeprecate StatusBar for now.

Test Plan

yolo

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels May 15, 2019
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cpojer in a203ebe.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 15, 2019
@turnrye
Copy link
Contributor

turnrye commented Jun 2, 2019

"yolo"

M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
There has been push back to remove this module from React Native. Since it is contentious, let's revert the deprecation and table this conversation until later.

## Changelog

[General] [Changed] - Undeprecate StatusBar for now.
Pull Request resolved: facebook#24860

Differential Revision: D15351835

Pulled By: cpojer

fbshipit-source-id: 2f40f3a8f17ab7631bf5441cd6528b04103e7821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: StatusBar Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants