Fix: text shadow displays on iOS when textShadowOffset is {0,0}

[woodpav]

Summary

There is a problem rendering text shadows on iOS. If the offset of the text shadow is {width:0,height:0}, the shadow does not display. This prevents you from representing a light directly above the text. This occurs because a text shadow only renders if the offset is a non-zero CGRect {width:0,height:0}.

My change checks textShadowRadius instead. If textShadowRadius is not nan then the user is rendering a text shadow. There are no situations to render a shadow without textShadowRadius making it a good variable to check.

This PR fixes this stale issue: #17277

Changelog

[iOS] [Fixed] - Text shadow now displays when the textShadowOffset is {width:0,height:0}

Test Plan

textShadowOffset: {width:0,height: 0},
textShadowRadius: 10,
textShadowColor: "black"

Before, without fix:

After with fix:

[cpojer]

Can you show a before and after screenshot of this behavior change and include it in the test plan section?

[woodpav]

Done.

[cpojer]

Awesome, thank you :)

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @a-googler in 9b63b50.

^{When will my fix make it into a release? | Upcoming Releases}

[willnorris]

in case anyone's interested... this got attributed to @a-googler because of the use of "[email protected]" as author email. @woodpav, I'm just curious, do you intentionally have your git client configured that way?

[woodpav]

I set it up without an email because I didn't have one I wanted made public. I guess it defaulted to that for some reason. I guess it's too late to change?

[cpojer]

That was actually my doing. I only had a few minutes to land this in the morning today and it failed to import at fb because it had no email assigned. I amended and force pushed with a generic email that I thought was a black hole. I didn’t think anybody would have that one actually registered. Lol.

…

________________________________ From: Will Norris <[email protected]> Sent: Thursday, April 11, 2019 18:59 To: facebook/react-native Cc: Christoph Nakazawa; Mention Subject: Re: [facebook/react-native] Fix: text shadow displays on iOS when textShadowOffset is {0,0} (#24398) in case anyone's interested... this got attributed to @a-googler<https://github.com/a-googler> because of the use of "[email protected]<mailto:[email protected]>" as author email. @woodpav<https://github.com/woodpav>, I'm just curious, do you intentionally have your git client configured that way? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#24398 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAA0KJHzQKLW0JOBEHxYDzWDtdv18jvXks5vf3figaJpZM4coBOm>.

[willnorris]

given that this has already been merged, yes it's too late. If you just want to keep your email private, see https://help.github.com/en/articles/about-commit-email-addresses for a special @users.noreply.github.com email you can use.

[woodpav]

No worries @cpojer I cede the glory for isnan(_textShadowRadius)) to you!

@willnorris I have decided to step out of the shadows and add a developer email to my future commits. I will not fade from the annals of history anymore!

P.S. Thank you for your work on rn. Words alone cannot express my gratitude.