[iOS] Fix triangle views on iOS #23402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
PR looks fine, but I'm hesitant to merge this until the fix has been verified (from your test plan, it looks like it has not been tested). |
|
@zhongwuzw as @hramos says, can you find a way (or a person) to test this? |
|
I test it in iOS simulator and real device. you can checkout the code here: https://github.com/horacioh/react-native-pull-test-23402 the way I test it was:
please let me know if this suits the needed test! @zhongwuzw @hramos |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhongwuzw merged commit 7a6fe0c into |
hramos
removed
Import Started
grabbou
pushed a commit
that referenced
this pull request
Apr 8, 2019
Summary: Fixes #22824 #21945 , the bug comes from #21208 , it was to fix #11897. Now Let's constrain edge adjust only when view has corners. [iOS] [Fixed] - Fix triangle views on iOS Pull Request resolved: #23402 Differential Revision: D14059192 Pulled By: hramos fbshipit-source-id: be613bf056d3cc484f281f7ea3d08f251971700a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22824 #21945 , the bug comes from #21208 , it was to fix #11897. Now Let's constrain edge adjust only when view has corners.
Changelog
[iOS] [Fixed] - Fix triangle views on iOS
Test Plan
Fixes issues like #11897 and #22824 #21945 , but attention, I'm not have device like comment in #11897, so I didn't test issue in #11897, but maybe I didn't break it, because only view which has corner may have issue like #11897.