[Standalone for NativeComponents] AndroidViewPagers.js

[Kriyszig]

[Android][Changed] - All the imports connected to requireNativeComponent in ViewPager was moved to a separate file.
Issue in focus: #22990

Test Plan:

• yarn test
• yarn flow
• yarn lint

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pull-bot]

	Warnings
⚠️	📋 Changelog - This PR appears to be missing Changelog.

Generated by 🚫 dangerJS

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[Kriyszig]

@TheSavior, sorry for the ping but I'm not quite able to comprehend the NSInternalInconsistencyException being thrown during the IOS build. Did this arise as a result of the changes I have made cause I couldn't link them to ViewPager

[elicwhite]

I think the iOS errors are unrelated.

Thanks for moving this out into its own file! One of the important parts of this issue is to define the flow type for this component. Can you help do that for this PR? You can probably figure out most of the type by looking at the file that originally included the call site and the props passed to it.

For the syntax of how to do this you can take a look at SwitchNativeComponent.js

[Kriyszig]

Thanks for the clarification. On it! (^_^)

[analysis-bot]

Code analysis results:

• eslint found some issues.

[analysis-bot]

Code analysis results:

• eslint found some issues.

[Kriyszig]

@TheSavior, Sorry for the delay, I was having minor trouble with implementing the flow type for the component. I have run into the problem of inexact types and have tried various ways to counter it without any success [ci/circleci: analyze]. I have not made any changes to the part throwing this error and am having a hard time finding a solution. Would love some direction to solve this (^_^)

[Kriyszig]

Nevermind, I found the error 😅. The PageScrollStateChanged had a flaw right from the beginning where type of actual parameter wasn't matching with what was declared in the formal parameter. Changes made in the latest commit made the two consistent. I'm sorry for the ping, should have looked at the error message harder. Thank you

[facebook-github-bot]

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Thanks for the PR! While your change is technically breaking, I think you are changing the callback to be consistent so it makes sense to me to change.

[Kriyszig]

I observed the call to be inconsistent with the rest and found a hard time writing the flow type. When I cross referenced with the other calls, the parameters always seemed to be an event and hence decided to change it. I was waiting for a review to verify whether that decision was right or wrong. Thanks for the approval (^_^)

[react-native-bot]

@VisibleMarkov merged commit ec488dc into facebook:master.