Fixed for supporting mediaPlaybackRequiresUserAction under iOS 10. #22208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
|
This fix was merged into react-native-webview and released. I hope it will be merged into RN if possible. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kelset
pushed a commit
that referenced
this pull request
Dec 12, 2018
…22208) Summary: There is a problem that the `mediaPlaybackRequiresUserAction` property does not work in WKWebView(`useWebKit`) under iOS 10. I fully know you are currently working to migrate the core's WebView to the standalone `react-native-webview` project. This has already been submitted to PR in `react-native-webview` and will be merged soon. I hope this fix applies to `react-native` before your migration is done. Pull Request resolved: #22208 Differential Revision: D13334868 Pulled By: cpojer fbshipit-source-id: f2a811a477054155ed5fe62ab31e4d63f70e7848
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem that the
mediaPlaybackRequiresUserActionproperty does not work in WKWebView(useWebKit) under iOS 10.I fully know you are currently working to migrate the core's WebView to the standalone
react-native-webviewproject. This has already been submitted to PR inreact-native-webviewand will be merged soon. I hope this fix applies toreact-nativebefore your migration is done.Test Plan:
I checked that
mediaPlaybackRequiresUserActionproperty works in my service as intended. I think this is a small change that is less likely to cause problems.Release Notes:
[IOS] [BUGFIX] [React/Views/RCTWKWebView.m] - Fixed for
mediaPlaybackRequiresUserActionin WKWebView under iOS 10.