Added groupCollapsed polyfill

[Eyesonly88]

groupCollapsed is used to group logs but collapsed which is very useful when the console has many logs (e.g. when using redux-logger).

For developers who prefer to debug iOS apps using Safari JSC, the groupCollapsed was not polyfilled.

Fixes #21446

Test Plan:

I tested it in the Safari Developer console.

Input:

console.groupCollapsed('Hello RN')
console.log('some data', {hello: "world"})
console.log('another line')
console.log('and another one')
console.groupEnd()

Output:
A single collapsed log containing the other logs as expected. See demo below.

Demo:

Release Notes:

[GENERAL] [ENHANCEMENT] [JSC] - Added groupCollapsed to the console polyfill to enable log collapsing in consoles such as Safari

[analysis-bot]

Code analysis results:

• eslint found some issues.

[analysis-bot]

prettier/prettier: Delete ⏎

[newyankeecodeshop]

I think this should be the consoleGroupPolyfill. I believe console.groupCollapsed should behave the same as console.group in a non-debugger environment logging to the OS.

[Eyesonly88]

Hey @newyankeecodeshop if I use consoleGroupPolyfill then the log won't be collapsed because of GROUP_OPEN inside consoleGroupPolyfill.

[newyankeecodeshop]

@Eyesonly88 I don't understand how the GROUP_OPEN character vs. GROUP_CLOSE makes a difference about whether the group is shown collapsed. When you attach the Safari debugger to the JSContext, is it still using the console polyfill?

[Eyesonly88]

@newyankeecodeshop Yes it is using the console polyfill. Without my code, there is no groupCollapsed. As you can see in the demo, using GROUP_CLOSE makes it collapsed.

[koenpunt]

groupCollapsed isn't there because the console object in the JSC is not the original console object. The original one is called after using a polyfill method;

react-native/Libraries/polyfills/console.js

Lines 541 to 549 in 3592122

	Object.keys(console).forEach(methodName => {
	const reactNativeMethod = console[methodName];
	if (originalConsole[methodName]) {
	console[methodName] = function() {
	originalConsole[methodName](...arguments);
	reactNativeMethod.apply(console, arguments);
	};
	}
	});

[Eyesonly88]

Exactly.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Thanks for the PR. Seems like it previously fell through the radar. Sorry about that!

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

@Eyesonly88 merged commit 638d672 into facebook:master.