Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlowCleanup] Split ViewAccessibility into DeprecatedViewAccessibility and rename r… #21422

Closed
wants to merge 1 commit into from
Closed

[FlowCleanup] Split ViewAccessibility into DeprecatedViewAccessibility and rename r… #21422

wants to merge 1 commit into from

Conversation

danibonilha
Copy link
Contributor

This PR splits and renames all references of ViewAccessibility to DeprecatedViewAccessibility
Related to #21342

Test Plan:

yarn flow-check-ios
yarn flow-check-android
yarn prettier
  • All flow checks pass.

Release Notes:

[GENERAL] [ENHANCEMENT] [Libraries/DeprecatedPropTypes/DeprecatedViewAccessibility.js] - Created
[GENERAL] [ENHANCEMENT] [ViewAccessibility.js] - Only flow types.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2018
RSNara
RSNara approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hramos hramos changed the title Split ViewAccessibility into DeprecatedViewAccessibility and rename r… [FlowCleanup] Split ViewAccessibility into DeprecatedViewAccessibility and rename r… Oct 1, 2018
facebook-github-bot
facebook-github-bot reviewed Oct 1, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@danibonilha merged commit 0de99bc into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 5, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 5, 2018
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@danibonilha @facebook-github-bot
Split ViewAccessibility into DeprecatedViewAccessibility and rename r… (
0de7dce 
facebook#21422)

Summary:
This PR splits and renames all references of ViewAccessibility to DeprecatedViewAccessibility
Related to facebook#21342
Pull Request resolved: facebook#21422

Reviewed By: yungsters

Differential Revision: D10132659

Pulled By: RSNara

fbshipit-source-id: 68c371230c69ed37c3e44bf8a36043adb04afc78
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@RSNara RSNara RSNara approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danibonilha @react-native-bot @RSNara @facebook-github-bot