Incorrect ref API usage fixed. #20913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Holdon on that, I need to finish some testing, I might go too aggressive - not sure about the global_ref yet, need to make sure it doesn't break anything. |
Generated by 🚫 dangerJS |
react-native-bot
added
Core Team
Missing Changelog
… global_ref doesn't call deallocator, in fact it makes the caller responsible for deletion of the reference, while otherwise the reference is released on scope leave.
dryganets
force-pushed
the
sergeyd/reference-leaks-fixes
branch
from
74cd97f to
cc26fea
Compare
|
I left only fix relevant to the issue. Everything else was correct. |
react-native-bot
added
✅Release Notes
and removed
Missing Changelog
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 31, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: release method of local_ref and global_ref doesn't call deallocator, in fact, it leaves the caller responsible for deletion of the reference, while otherwise the reference is released on scope left. Fixes facebook#18292. Pull Request resolved: facebook#20913 Differential Revision: D9616237 Pulled By: hramos fbshipit-source-id: 021aa3e4f039e6b7a98da3e4224c1ee49d5a4921
kelset
pushed a commit
that referenced
this pull request
Nov 9, 2018
Summary: release method of local_ref and global_ref doesn't call deallocator, in fact, it leaves the caller responsible for deletion of the reference, while otherwise the reference is released on scope left. Fixes #18292. Pull Request resolved: #20913 Differential Revision: D9616237 Pulled By: hramos fbshipit-source-id: 021aa3e4f039e6b7a98da3e4224c1ee49d5a4921
react-native-bot
removed
the
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: release method of local_ref and global_ref doesn't call deallocator, in fact, it leaves the caller responsible for deletion of the reference, while otherwise the reference is released on scope left. Fixes facebook#18292. Pull Request resolved: facebook#20913 Differential Revision: D9616237 Pulled By: hramos fbshipit-source-id: 021aa3e4f039e6b7a98da3e4224c1ee49d5a4921
elicwhite
added
p: Microsoft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release method of local_ref and global_ref doesn't call deallocator, in fact, it leaves the caller responsible for deletion of the reference, while otherwise the reference is released on scope left.
Fixes #18292.
Test Plan:
If there is a mistake in the change it won't even run.
Pass the big array (bigger than 512 elements) and call importTypes method on it. If it doesn't crash the problem is fixed.
Release Notes:
[ANDROID] [BUGFIX] [JNI] - Fixes spontaneous local_ref table overflow.