added extra sinopia config to support packages #20789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that babel uses scoped packages the extra sinpoia config also requires the rule to cover ** which will satisfy such repositories like @babel/core
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
Missing Test Plan
hramos
approved these changes
Aug 22, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
approved these changes
Aug 23, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @falconmick in e3165c6. Once this commit is added to a release, you will see the corresponding version tag below the description at e3165c6. If the commit has a single |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 28, 2018
Summary: [DOCS] [BUGFIX] [react-native-cli/README.md] - fixed sinopia configuration docs now that babel uses scoped packages the extra sinpoia config also requires the rule to cover ** which will satisfy such repositories like babel/core The only other issue I had with getting started using this doc was node-gyp being an absolute horror to get running (a dependancy of sinpoia) I don't really know if writing debugging tips/links for macos in these docs is relevant. Pull Request resolved: facebook/react-native#20789 Differential Revision: D9468340 Pulled By: hramos fbshipit-source-id: c7a41f384655b36e5e46b39d1e7e14313cab9f68
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: [DOCS] [BUGFIX] [react-native-cli/README.md] - fixed sinopia configuration docs now that babel uses scoped packages the extra sinpoia config also requires the rule to cover ** which will satisfy such repositories like babel/core The only other issue I had with getting started using this doc was node-gyp being an absolute horror to get running (a dependancy of sinpoia) I don't really know if writing debugging tips/links for macos in these docs is relevant. Pull Request resolved: facebook#20789 Differential Revision: D9468340 Pulled By: hramos fbshipit-source-id: c7a41f384655b36e5e46b39d1e7e14313cab9f68
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DOCS] [BUGFIX] [react-native-cli/README.md] - fixed sinopia configuration docs
now that babel uses scoped packages the extra sinpoia config also
requires the rule to cover ** which will satisfy such repositories like
@babel/core
The only other issue I had with getting started using this doc was node-gyp being an absolute horror to get running (a dependancy of sinpoia) I don't really know if writing debugging tips/links for macos in these docs is relevant.