Exposed scrollEnabled on TextInput

[baldursson]

On iOS, it is not possible to select a range of text using a Text component (see #13938). Because of how the Text component is implemented on iOS, this will not work without a complete re-write. On Android however, this is not an issue.

As the TextInput component has evolved, it can more or less be used as a drop-in replacement on iOS by setting multiline={true} and editable={false}. Except for one detail: the text input field has scrolling activated and it's not possible to turn off. (See #1391 and #15962).

This pull request addresses that issue, simply by exposing the scrollEnabled property:

<TextInput
    multiline
    editable={false}
    scrollEnabled={false}
  />

Test Plan

1. Create a multiline TextInput component, with the attributes presented above.
2. Run on iOS
3. The TextInput field should not be able to scroll

Related PRs

facebook/react-native-website#367

Release Notes

[IOS] [FEATURE] [TextInput] - Made it possible to turn off scrolling on a multiline TextInput component

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pull-bot]

	Warnings
⚠️	❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[L-Yeiser]

Thank you for putting the work in on this! This is exactly what we needed.

[facebook-github-bot]

@baldursson I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[brenwell]

This is exactly what i need too, Thanks. Can't wait for it to be merged

[baldursson]

@shergin Are you able to review this? It's really a no-brainer

[facebook-github-bot]

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @baldursson in 6104123.

Once this commit is added to a release, you will see the corresponding version tag below the description at 6104123. If the commit has a single master tag, it is not yet part of a release.