Bring back TextInput.State, deprecate focusTextInput and blurTextInput #18936
Conversation
facebook-github-bot
added
the
CLA Signed
| statics: { | ||
| State: { | ||
| currentlyFocusedField: TextInputState.currentlyFocusedField, | ||
| focusTextInput: TextInputState.focusTextInput, |
There was a problem hiding this comment.
Also kept those 2 as I suspect it might break things if we remove it without warning. Not sure if we want to deprecate since there are no real alternative except using TextInput refs for focus / blur but some people might use it outside the component tree...
There was a problem hiding this comment.
The proper way is to call .focus() or .blur() on the ref. How would you even get a node handle for it? I'd rather not add this back.
There was a problem hiding this comment.
It is usually used in combination with currentlyFocusedField, which is the node handle. There is also findNodeHandle. I agree the other API is preferable, but there might be valid use cases for TextInput.State one, like the keyboard library I noticed the issue in. If we still want to remove this we should probably deprecate it for a release cycle first.
There was a problem hiding this comment.
We have Keyboard.dismiss (or dismissKeyboard) for blurring the focused field.
If you will take care of deprecating it then removing it in the next release, we can add it back.
There was a problem hiding this comment.
Makes sense, The only one that there is no alternative currently is currentlyFocusedField, which is useful to measure where the focused the input is in the screen (example: https://github.com/APSL/react-native-keyboard-aware-scroll-view/blob/master/lib/KeyboardAwareHOC.js#L267). I will add a deprecation warning to the other 2 methods.
react-native-bot
added
Core Team
Component: TextInput
|
@sophiebits Could you have a look a this? |
| statics: { | ||
| State: { | ||
| currentlyFocusedField: TextInputState.currentlyFocusedField, | ||
| focusTextInput: TextInputState.focusTextInput, |
There was a problem hiding this comment.
The proper way is to call .focus() or .blur() on the ref. How would you even get a node handle for it? I'd rather not add this back.
|
Split the PR, this is now only the TextInput.State part, see #19255 for the other. |
|
👍 thanks! |
janicduplessis
changed the title
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: a275eac removed TextInput.State but we should keep it as it was a public-ish API and we don't have any migration plan off it. Also bring back `focusTextInput` and `blurTextInput` with a deprecation warning. Tested TextInput.State is back [GENERAL][ENHANCEMENT][TextInput] - Bring back TextInput.State, deprecate focusTextInput and blurTextInput Closes facebook#18936 Differential Revision: D8044439 Pulled By: hramos fbshipit-source-id: fde145f04bb1d46ef58b5954cb7963adf495b21c
…extInput (#20326) Summary: In #18936 we decided to deprecate `focusTextInput` and `blurTextInput` but since then I found a valid use case for it that is pretty much impossible to implement otherwise. React Navigation uses it to blur / re-focus the input during the swipe back gesture. Blur can be done with Keyboard.dismiss but without this api we cannot re-focus the text field that was focused if the swipe back gesture is cancelled. See https://github.com/react-navigation/react-navigation/blob/master/src/navigators/createKeyboardAwareNavigator.js#L21-L34 I think it is best to just bring back this api. Pull Request resolved: #20326 Differential Revision: D9182810 Pulled By: hramos fbshipit-source-id: 3740421ffafb8f814522d15788f3466324177c16
…extInput (#20326) Summary: In #18936 we decided to deprecate `focusTextInput` and `blurTextInput` but since then I found a valid use case for it that is pretty much impossible to implement otherwise. React Navigation uses it to blur / re-focus the input during the swipe back gesture. Blur can be done with Keyboard.dismiss but without this api we cannot re-focus the text field that was focused if the swipe back gesture is cancelled. See https://github.com/react-navigation/react-navigation/blob/master/src/navigators/createKeyboardAwareNavigator.js#L21-L34 I think it is best to just bring back this api. Pull Request resolved: #20326 Differential Revision: D9182810 Pulled By: hramos fbshipit-source-id: 3740421ffafb8f814522d15788f3466324177c16
a275eac removed TextInput.State but we should keep it as it was a public-ish API and we don't have any migration plan off it. Also bring back
focusTextInputandblurTextInputwith a deprecation warning.Test Plan
Tested TextInput.State is back
Release Notes
[GENERAL][ENHANCEMENT][TextInput] - Bring back TextInput.State, deprecate focusTextInput and blurTextInput