Handle update of secureTextEntry of TextInput in iOS

[lucasbento]

This PR fixes #5859, which causes the TextInput to have a space appended to the end when you change the value of secureTextEntry prop in iOS:

Before	After

I found a few workarounds online and the simplest one in my opinion is this SO answer.

I'm definitely open to hear more opinions on the implementation.

Test Plan

My test plan is very basic, having a <TextInput /> and dynamically switching secureTextEntry prop between true/false will show the bug.

Release Notes

[IOS] [BUGFIX] [Libraries/Text/TextInput/RCTBaseTextInputView.m] - Fix bug with space being appended to the end of input value when changing secureTextEntry.

[RWOverdijk]

Perhaps document that this is a "hack". For the rest, I'm just glad to see this working, but can't help but think that this should be fixed elsewhere.

</two_cents>

[janicduplessis]

Can you add a setter for secureTextEntry instead of using didSetProps? Something like:

- (void)setSecureTextEntry:(BOOL)secureTextEntry
{
  [super setSecureTextEntry:secureTextEntry];
  
  ...
}

Also I agree we should add a comment about what this does and a link to the SO post.

[lucasbento]

Hey @janicduplessis, thank you for reviewing.

Where exactly should I put it? Do I have to add it and listen to the prop changes somewhere?

[lucasbento]

@janicduplessis: can you take a look? :)

[lucasbento]

@janicduplessis: would you mind taking a look? :)

[lucasbento]

@shergin: perhaps you can take a look at this?

[hramos]

By Facebook team, they were probably referring to me as I was busy with some other tasks around that time (April). Looking at this PR, I see @janicduplessis already reviewed it and provided some feedback that doesn't seem to be addressed yet.

[lucasbento]

@hramos: I'm waiting for a reply on this: #18587 (comment).

I just need to know where to put the code specified by @janicduplessis.

[hramos]

Looks like the review feedback hasn't been addressed yet. I know there's a question out to Janic on how the feedback should be implemented, but that's not for me to answer.

I'll add that this PR would greatly benefit from adding a test case.

[ericlewis]

@hramos I opened #23524 which addresses Janic's feedback.

[cpojer]

Closing in favor of the new PR.