Added transitions 'VerticalUpSwipeJump' and 'VerticalDownSwipeJump' in… #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NavigatorSceneConfigs
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Hi, I made one video for show the animation https://drive.google.com/file/d/0BwY3eLp5Z-sccjlaQUtZMlFBVGc/view?usp=sharing Best regards! |
|
@vjeux something wrong in this code? Best regards. |
| }, | ||
| }; | ||
|
|
||
| var FromTheUp = { |
There was a problem hiding this comment.
Maybe FromTheTop instead?
There was a problem hiding this comment.
Yes, it gets better! I will change, thank you.
|
@ericvicenti done. I changed the interpolator name. |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1607694279505716/int_phab to review. |
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… NavigatorSceneConfigs