Fix #17610, Add fixtures to metro blacklist #17672

t4deu · 2018-01-19T13:05:27Z

Include a default blacklist into the build settings to prevent
processing of incorrect fixture files by Metro.

Motivation

Fix #17610 issue, preventing metro from processing fixture files

Test Plan

Have a working demo
Install https://github.com/oblador/react-native-vector-icons
Use in a component
Start the app
The app starts successfully and display the icons

Related PRs

Release Notes

[ GENERAL ] [ BUGFIX ] [local-cli/util/Config.js] - Add default file blacklist

pull-bot · 2018-01-19T13:06:14Z

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

eslint-bot · 2018-01-19T13:06:38Z

local-cli/util/Config.js

@@ -19,6 +19,8 @@ const path = require('path');

 const {Config: MetroConfig} = require('metro');

+const blacklist = require('metro/src/blacklist')


semi: Missing semicolon.

eslint-bot · 2018-01-19T13:06:38Z

local-cli/util/Config.js

@@ -56,6 +58,10 @@ const getProjectRoots = () => {
  return resolveSymlinksForRoots([getProjectPath()]);
 };

+const getBlacklistRE = () => {
+  return blacklist([/.*\/__fixtures__\/.*/])


semi: Missing semicolon.

eslint-bot · 2018-01-19T13:12:12Z

local-cli/util/Config.js

@@ -56,6 +58,10 @@ const getProjectRoots = () => {
  return resolveSymlinksForRoots([getProjectPath()]);
 };

+const getBlacklistRE = () => {


semi: Missing semicolon.

eslint-bot · 2018-01-19T13:13:22Z

local-cli/util/Config.js

@@ -56,6 +58,10 @@ const getProjectRoots = () => {
  return resolveSymlinksForRoots([getProjectPath()]);
 };

+const getBlacklistRE = () => {


prettier/prettier: Insert ;

eslint-bot · 2018-01-19T13:13:22Z

local-cli/util/Config.js

@@ -56,6 +58,10 @@ const getProjectRoots = () => {
  return resolveSymlinksForRoots([getProjectPath()]);
 };

+const getBlacklistRE = () => {


semi: Missing semicolon.

eslint-bot · 2018-01-19T13:18:37Z

local-cli/util/Config.js

@@ -19,6 +19,8 @@ const path = require('path');

 const {Config: MetroConfig} = require('metro');

+const blacklist = require('metro/src/blacklist');


metro/src/blacklist Required module not found

vovkasm · 2018-01-25T06:32:43Z

@t4deu Thank you for solution. One question, will it correctly work with custom rn-cli.config.js in project root with custom getBlacklistRE function? I remember that some logic that merges blacklist exists in RN or metro sources, but not sure...

t4deu · 2018-01-25T11:12:13Z

Hi @vovkasm, yes it works well, react already handles the default and custom settings merging 😃

chirag04 · 2018-01-29T22:17:53Z

cc @rafeca

MoOx

Nice work

Titozzz · 2018-02-07T17:49:31Z

Please merge it asap, it breaks react-native-vector-icons

tiresomefanatic · 2018-02-12T21:01:02Z

C:\Users\Admin\Desktop\Rawster>react-native run-android
C:\Users\Admin\Desktop\Rawster\node_modules\babel-core\lib\transformation\file\index.js:590
throw err;
^

SyntaxError: C:/Users/Admin/Desktop/Rawster/node_modules/react-native/local-cli/util/Config.js: Unexpected token (132:0)
130 |
131 | module.exports = Config;

132 |
| ^
at Parser.pp$5.raise (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:4454:13)
at Parser.pp.unexpected (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:1761:8)
at Parser.pp$3.parseExprAtom (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3750:12)
at Parser.pp$3.parseExprSubscripts (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3494:19)
at Parser.pp$3.parseMaybeUnary (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3474:19)
at Parser.pp$3.parseExprOps (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3404:19)
at Parser.pp$3.parseMaybeConditional (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3381:19)
at Parser.pp$3.parseMaybeAssign (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3344:19)
at Parser.parseMaybeAssign (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:6474:20)
at Parser.pp$3.parseExpression (C:\Users\Admin\Desktop\Rawster\node_modules\babylon\lib\index.js:3306:19)

I get this error while trying this method

t4deu · 2018-02-13T11:19:52Z

@tiresomefanatic you shoud look in #17610 comments for the temporary fix

Include a default blacklist in the build settings to prevent processing of incorrect fixture files by Metro.

t4deu · 2018-02-14T18:37:10Z

Just rebased, please @hramos is there anything that need to be done so it can be merged?

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Include a default blacklist into the build settings to prevent processing of incorrect fixture files by Metro.  Fix facebook#17610 issue, preventing metro from processing fixture files 1. Have a working demo 2. Install https://github.com/oblador/react-native-vector-icons 3. Use in a component 4. Start the app 5. The app starts successfully and display the icons [ GENERAL ] [ BUGFIX ] [local-cli/util/Config.js] - Add default file blacklist Closes facebook#17672 Differential Revision: D7014627 Pulled By: hramos fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9

jeanlauliac · 2018-02-19T14:38:24Z

@t4deu Thank you for solution. One question, will it correctly work with custom rn-cli.config.js in project root with custom getBlacklistRE function? I remember that some logic that merges blacklist exists in RN or metro sources, but not sure...

No, pretty sure this will not get merged. I'm looking for a more long-term solution to prevent that problem. EDIT: though we could change the logic to merge regexes. But I think not publishing __fixtures__ folders in the first place is a more robust solution, that I propose in #18019.

This task is related to facebook/metro#139 I think.

Summary: Include a default blacklist into the build settings to prevent processing of incorrect fixture files by Metro.  Fix #17610 issue, preventing metro from processing fixture files 1. Have a working demo 2. Install https://github.com/oblador/react-native-vector-icons 3. Use in a component 4. Start the app 5. The app starts successfully and display the icons [ GENERAL ] [ BUGFIX ] [local-cli/util/Config.js] - Add default file blacklist Closes #17672 Differential Revision: D7014627 Pulled By: hramos fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9

Summary: This try to address #17672 and facebook/metro#139. We should probably not include these folders in the released version of React Native, as they are used only for testing—am I incorrect? cc MoOx, t4deu. I ran: ``` npm pack tar -t -f react-native-1000.0.0.tgz | less ``` Then verified that `__fixture__` was not part of the package. #17672 [GENERAL] [BUGFIX] [.npmignore] - Do not publish test-specific files Closes #18019 Differential Revision: D7098211 Pulled By: jeanlauliac fbshipit-source-id: 0748ad8c064450bd2a9f4d6f49675a7f74fb300f

Summary: Include a default blacklist into the build settings to prevent processing of incorrect fixture files by Metro.  Fix facebook#17610 issue, preventing metro from processing fixture files 1. Have a working demo 2. Install https://github.com/oblador/react-native-vector-icons 3. Use in a component 4. Start the app 5. The app starts successfully and display the icons [ GENERAL ] [ BUGFIX ] [local-cli/util/Config.js] - Add default file blacklist Closes facebook#17672 Differential Revision: D7014627 Pulled By: hramos fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9

Summary: Include a default blacklist into the build settings to prevent processing of incorrect fixture files by Metro.  Fix #17610 issue, preventing metro from processing fixture files 1. Have a working demo 2. Install https://github.com/oblador/react-native-vector-icons 3. Use in a component 4. Start the app 5. The app starts successfully and display the icons [ GENERAL ] [ BUGFIX ] [local-cli/util/Config.js] - Add default file blacklist Closes facebook/react-native#17672 Differential Revision: D7014627 Pulled By: hramos fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9

Summary: This try to address #17672 and facebook/metro#139. We should probably not include these folders in the released version of React Native, as they are used only for testing—am I incorrect? cc MoOx, t4deu. I ran: ``` npm pack tar -t -f react-native-1000.0.0.tgz | less ``` Then verified that `__fixture__` was not part of the package. facebook/react-native#17672 [GENERAL] [BUGFIX] [.npmignore] - Do not publish test-specific files Closes facebook/react-native#18019 Differential Revision: D7098211 Pulled By: jeanlauliac fbshipit-source-id: 0748ad8c064450bd2a9f4d6f49675a7f74fb300f

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 19, 2018

eslint-bot reviewed Jan 19, 2018

View reviewed changes

t4deu force-pushed the fix/blacklist_fixtures branch from 2f6a461 to 2586bd9 Compare January 19, 2018 13:12

eslint-bot reviewed Jan 19, 2018

View reviewed changes

t4deu force-pushed the fix/blacklist_fixtures branch from 2586bd9 to c7d09b6 Compare January 19, 2018 13:17

eslint-bot reviewed Jan 19, 2018

View reviewed changes

MoOx approved these changes Feb 2, 2018

View reviewed changes

t4deu force-pushed the fix/blacklist_fixtures branch from c7d09b6 to d2ae4bb Compare February 14, 2018 17:51

Fix facebook#17610, Add fixtures to metro blacklist

e9f7883

Include a default blacklist in the build settings to prevent processing of incorrect fixture files by Metro.

t4deu force-pushed the fix/blacklist_fixtures branch from d2ae4bb to e9f7883 Compare February 14, 2018 18:04

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 16, 2018

facebook-github-bot approved these changes Feb 16, 2018

View reviewed changes

facebook-github-bot closed this in 54dc11a Feb 17, 2018

t4deu deleted the fix/blacklist_fixtures branch February 18, 2018 00:03

This was referenced Feb 19, 2018

npmignore: ignore tests and fixtures #18019

Closed

Metro 0.25+ is resolving package.json within react-native/.../__fixtures__ directory facebook/metro#139

Open

vodchella mentioned this pull request Feb 21, 2018

react-native-vector-icons и RN 0.52-0.53 vodchella/alpinebook#32

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #17610, Add fixtures to metro blacklist #17672

Fix #17610, Add fixtures to metro blacklist #17672

t4deu commented Jan 19, 2018 •

edited

Loading

pull-bot commented Jan 19, 2018 •

edited

Loading

eslint-bot Jan 19, 2018

eslint-bot Jan 19, 2018

eslint-bot Jan 19, 2018

eslint-bot Jan 19, 2018

t4deu Jan 19, 2018

eslint-bot Jan 19, 2018

t4deu Jan 19, 2018

eslint-bot Jan 19, 2018

vovkasm commented Jan 25, 2018

t4deu commented Jan 25, 2018

chirag04 commented Jan 29, 2018

MoOx left a comment

Titozzz commented Feb 7, 2018

tiresomefanatic commented Feb 12, 2018

t4deu commented Feb 13, 2018

t4deu commented Feb 14, 2018 •

edited

Loading

facebook-github-bot left a comment

jeanlauliac commented Feb 19, 2018 •

edited

Loading

		@@ -19,6 +19,8 @@ const path = require('path');

		const {Config: MetroConfig} = require('metro');

		const blacklist = require('metro/src/blacklist')

Fix #17610, Add fixtures to metro blacklist #17672

Fix #17610, Add fixtures to metro blacklist #17672

Conversation

t4deu commented Jan 19, 2018 • edited Loading

Motivation

Test Plan

Related PRs

Release Notes

pull-bot commented Jan 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vovkasm commented Jan 25, 2018

t4deu commented Jan 25, 2018

chirag04 commented Jan 29, 2018

MoOx left a comment

Choose a reason for hiding this comment

Titozzz commented Feb 7, 2018

tiresomefanatic commented Feb 12, 2018

t4deu commented Feb 13, 2018

t4deu commented Feb 14, 2018 • edited Loading

facebook-github-bot left a comment

Choose a reason for hiding this comment

jeanlauliac commented Feb 19, 2018 • edited Loading

t4deu commented Jan 19, 2018 •

edited

Loading

pull-bot commented Jan 19, 2018 •

edited

Loading

t4deu commented Feb 14, 2018 •

edited

Loading

jeanlauliac commented Feb 19, 2018 •

edited

Loading