[ios] Import RCTTVRemoteHandler only on tvOS #17502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
@facebook-github-bot label Needs more information Attention: @shergin Generated by 🚫 dangerJS |
|
Verified this works for me too. @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Jan 10, 2018
Summary: Fix issue #17027 (`RCTModalHostView` has a tvOS dependency that was not wrapped in `TARGET_OS_TV`) Existing test automation should pass. [GENERAL] [BUGFIX] [tvOS] Fix cocoapods compile issue in RCTModalHostView Closes #17502 Differential Revision: D6688166 Pulled By: hramos fbshipit-source-id: 38297f439f75a8303f59f83b92e004c6c73d9bf6
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: Fix issue facebook#17027 (`RCTModalHostView` has a tvOS dependency that was not wrapped in `TARGET_OS_TV`) Existing test automation should pass. [GENERAL] [BUGFIX] [tvOS] Fix cocoapods compile issue in RCTModalHostView Closes facebook#17502 Differential Revision: D6688166 Pulled By: hramos fbshipit-source-id: 38297f439f75a8303f59f83b92e004c6c73d9bf6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issue #17027 (
RCTModalHostViewhas a tvOS dependency that was not wrapped inTARGET_OS_TV)Test Plan
Existing test automation should pass.
Release Notes
[GENERAL] [BUGFIX] [tvOS] Fix cocoapods compile issue in RCTModalHostView