Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when setting selectionColor on old android devices #16857

Closed
wants to merge 2 commits into from

Conversation

jeremistadler
Copy link
Contributor

@jeremistadler jeremistadler commented Nov 16, 2017

Setting selectionColor for TextInput crashes on sdk version 19

This just bails out instead of crashing.

Test plan

Start an emulator with android sdk 19

import React, { Component } from 'react';
import { TextInput } from 'react-native';
export default class App extends Component {
  render() {
    return (
      <TextInput
        value="hello"
        selectionColor="#aabbcc"
        style={{margin: 40}}
      />
    );
  }
}

Release Notes

[ANDROID] [BUGFIX] [TextInput] - setting selectionColor crashed on sdk 19

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2017
@jeremistadler
Copy link
Contributor Author

@facebook-open-source-bot run tests

Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: put return on new line with curly braces to match code style.

@shergin
Copy link
Contributor

shergin commented Nov 21, 2017

Actually, it was fixed in #14789.

@shergin shergin closed this Nov 21, 2017
@jeremistadler jeremistadler deleted the patch-2 branch November 21, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants