Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unrecognized selector error #15755

Closed
wants to merge 2 commits into from
Closed

Fix unrecognized selector error #15755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcea106
Fix unrecognized selector error
giladno Sep 1, 2017
b544350
Update RCTMultipartStreamReader.m
shergin Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion React/Base/RCTMultipartStreamReader.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ - (void)emitProgress:(NSDictionary *)headers
// Throttle progress events so we don't send more that around 60 per second.
CFTimeInterval currentTime = CACurrentMediaTime();

NSUInteger headersContentLength = headers[@"Content-Length"] != nil ? [headers[@"Content-Length"] unsignedIntValue] : 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsignedIntegerValue maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately no, both unsignedIntValue and unsignedIntegerValue breaks (at runtime)

Copy link

@krystofcelba krystofcelba Sep 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the statement can be changed to
NSInteger headersContentLength = headers[@"Content-Length"] != nil ? [headers[@"Content-Length"] intValue] : 0; so the value didn't have to be cast.

NSUInteger headersContentLength = headers[@"Content-Length"] != nil ? (NSUInteger)[headers[@"Content-Length"] intValue] : 0;
if (callback && (currentTime - _lastDownloadProgress > 0.016 || final)) {
_lastDownloadProgress = currentTime;
callback(headers, @(headersContentLength), @(contentLength));
Expand Down