troubleshooting docs #14885
troubleshooting docs #14885
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
@skevy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
The importer will refuse to land a PR if a commit is added right before a shipit command is made. This is to prevent unreviewed changes from making it in (even though 7e4af4f was made by the same person who ran shipit). I'll try landing again. |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
facebook-github-bot
added
the
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This won't land due to a disparity in what GitHub's API returns when we attempt to import the PR. A quick workaround would be to open a new PR with the same commits. Otherwise, I can find sometime in the next month to apply the changes manually in the internal repo. |
|
As suggested I opened a new PR #15304 |
Summary: I added troubleshooting docs for connection to the development server from device, otherwise it's maybe hard to find out why it's not working. Due to a disparity in what GitHub's API return the original PR (#14885) couldn't get imported, so I created a new PR as hramos suggested. Closes #15304 Differential Revision: D5537615 Pulled By: hramos fbshipit-source-id: b94e887b1b771be9e93854124bd0a56b27fd0097
I added troubleshooting docs for connection to the development server from device, otherwise it's maybe hard to find out why it's not working.