Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] CameraRoll support for Videos #13715

Closed
wants to merge 1,104 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1104 commits
Select commit Hold shift + click to select a range
546a43b
Expose offset parameters for ToastAndroid
mgoovaer Aug 4, 2017
fb371af
troubleshooting docs (clone #14885)
formatlos Aug 4, 2017
2323695
fix typo
vonovak Aug 4, 2017
b4f91be
Allow to fetch files over the network
Aug 4, 2017
ac43548
Native Animated - Restore default values when removing props on Android
janicduplessis Aug 4, 2017
23f72a9
Correctly handle the case where HEADER_SEARCH_PATHS is a single string
hramos Aug 4, 2017
6bcc56e
Adding documentation to useNativeDriver portion of the Animated API
mini-eggs Aug 4, 2017
aa9a40f
Update default .gitignore to work with fastlane setups in sub-folders
KrauseFx Aug 4, 2017
259eac8
Revert D5556439: [react-native][PR] Native Animated - Restore default…
strulovich Aug 4, 2017
5be8c4a
Cleanup stray markdown files, update contributing guidelines
hramos Aug 4, 2017
c5bd033
Add proper Stetho debugging setup documentation
louisgv Aug 4, 2017
b2fe048
always set camera distance on transforms, to default 1280 if 0
Aug 7, 2017
ec74a96
Set alertTitle in UILocalNotification
Aug 7, 2017
95d5d11
Fixed issue with install third party script in directory with spaces
gabrielbull Aug 7, 2017
614dd07
add `pinchEnabled` prop to ScrollView
jmurzy Aug 7, 2017
782453d
Fix indentation
davidaurelio Aug 7, 2017
1cd276a
Specialize JSCValueEncoder for id instead of NSArray
javache Aug 7, 2017
d42ccca
Allow native modules to customize the main-thread init behaviour
javache Aug 7, 2017
220034c
Configure requiresMainQueueSetup for core modules
javache Aug 7, 2017
72dae51
Expose didCloseWithCode in RCTReconnectingWebSocket
cpluss Aug 7, 2017
16e96a5
Remove unused RCTWebSocketObserverProtocol
javache Aug 7, 2017
5d79b26
Limit calls to SoLoader
javache Aug 7, 2017
2161f92
Add pertinent info for fresh flatlisters
GantMan Aug 8, 2017
be3f1be
Fixed ART Surface initialization: do not cancel updates to the surfce…
tepamid Aug 8, 2017
8d757e5
Export `Animated.Node` for ease of type checking
jamesreggio Aug 8, 2017
66a788f
Add locking around calls from JSCExecuter
Aug 8, 2017
898790d
add --port options to run-android, defaults to 8081
Aug 8, 2017
878b7e4
fishhook nwlog_legacy_v to avoid log spam on websocket reconnect
Aug 8, 2017
b65fd09
Add Performance in Marketplace blog post
hramos Aug 8, 2017
cc4de7a
Reject local-cli promises with Error objects
zertosh Aug 8, 2017
d013ba3
add perf marker that fires first time content is added to root view
bnham Aug 8, 2017
0e3117c
Fix format specifier used in RCTCxxMethod
kastiglione Aug 8, 2017
d9db3bc
Fishhook needs to support Apple TV
douglowder Aug 8, 2017
ad21ad2
Fix stale separator props and expose CellRenderer refs
olegbl Aug 9, 2017
bb7a78c
Add travis bot for react-native
pranaygp Aug 9, 2017
55117ea
Remove typed option loading
davidaurelio Aug 9, 2017
0241cb7
Improve definition of RCTNilIfNull
javache Aug 9, 2017
b06bfdd
Fix crash when converting NSNull values
javache Aug 9, 2017
d81e549
Fix format specifier used in RCTUIManager
kastiglione Aug 9, 2017
f06d992
Fix syntax error
JulienKode Aug 9, 2017
39eb6c5
Fix podspec test
javache Aug 9, 2017
c984d04
Merge fishhook.xcodeproj in RCTWebSocket
javache Aug 9, 2017
d268c1f
Upgrade fbjs-scripts
Aug 9, 2017
b78b8cc
Fix infinite recursion in RCTSettingsManager init
javache Aug 9, 2017
b1bb0a7
Wait for bridge to disappear when running tests
javache Aug 9, 2017
046f600
React 16 beta 5 sync (5495e49...c3718c4)
Aug 9, 2017
de4e51b
Make console work with JS engines which use print
Aug 10, 2017
460c5db
unbreak touching in prod mode
sophiebits Aug 10, 2017
b103903
Fix updating a view z-index on Android
janicduplessis Aug 10, 2017
f17b130
Fixes bad link in docs
kyledecot Aug 10, 2017
92dd6b9
Fix destructuring-style PropTypes references
sophiebits Aug 10, 2017
7e51547
LocalString doesn't have a check for nullptr
dryganets Aug 10, 2017
9075ff6
Fix typo
markneub Aug 10, 2017
d565bc3
Fix TextInput numeric keyboard submit
gontovnik Aug 10, 2017
c404425
Improve spacing in polyfill error messages
kashav Aug 10, 2017
3a031cc
Bring back React Stack support
alexeylang Aug 10, 2017
0e7375a
Apple TV: RCTTabBar selection controlled by native after render (fix …
Aug 10, 2017
cd9d6e3
WebSocket API change to make room for other connection options (SSL p…
rh389 Aug 10, 2017
9b30f56
Update Jest to 20.1.0-echo.1
Aug 10, 2017
5d4c6e5
Rename module name to module path
Aug 10, 2017
a9eaf6f
Switch soname from .so to .$(ext)
mzlee Aug 10, 2017
1df198d
Expose ModuleRegistry from Instance
Aug 10, 2017
4510760
React Native: run Relay DevTools runtime
Slava Aug 10, 2017
b06672e
TextInput: `onSubmitEditing` is now woriking with disabled `blurOnSub…
shergin Aug 11, 2017
64e9b24
Expose the ReactApplicationContext to createShadowNodeInstance()
ayc1 Aug 11, 2017
21b1ed3
autoGrow for RN TextInput
sumkit Aug 11, 2017
cf38b08
Implement lazy discovery scaffolding for loading NativeModules on dem…
Aug 11, 2017
2512a34
Add `@providesModule` to `IntegrationTests/WebViewTest.js`
davidaurelio Aug 11, 2017
f32d0ee
Refactor attachHMRServer to use async/await
rafeca Aug 11, 2017
8b2975a
Add multi-client support for HMR
rafeca Aug 11, 2017
37754c5
refactor MemoryPressureListener to use Android levels
cwdick Aug 12, 2017
2a6965d
Refactor memory management of RCTModuleMethod's arguments
fromcelticpark Aug 14, 2017
6783694
Add support for Cxx objects as arguments to native modules
fromcelticpark Aug 14, 2017
84e80eb
Allow reactinstancemanager to set an initialization function
Aug 14, 2017
419652d
Move native modules into different packages for fb4a shared bundle
Aug 14, 2017
f11f001
Gate more code with if (__DEV__) { }
alexeylang Aug 14, 2017
4150410
Force the debugger to disconnect before a bundle reload
pakoito Aug 14, 2017
475cf1a
Allow to pass regular expressions to `buildRegExps`
davidaurelio Aug 14, 2017
b58207e
remove internal copy of ReactNativeFeatureFlags
fkgozali Aug 14, 2017
ef23d2b
Show bundle download progress on iOS
janicduplessis Aug 14, 2017
68bbccb
Fix flowtype errors for PushNotificationIOS
radko93 Aug 14, 2017
7abce0b
Fix TextInput autoGrow
ayc1 Aug 15, 2017
ab9c788
RN babel preset: add import() syntax
Aug 15, 2017
353cb61
refactor out RootView tag number logic
aaronechiu Aug 15, 2017
e16dd51
Fix systrace section name
alexeylang Aug 15, 2017
091878a
fix content appeared logging
bnham Aug 15, 2017
66da0d2
move the ReactNativeFeatureFlags outside of sync dir
fkgozali Aug 15, 2017
6f60f2b
Expose StatusBar height and fix StatusBar example - T13591448
mdvacca Aug 15, 2017
25f2938
Getting correct video width and height metrics
Aug 15, 2017
4000202
Fetching video length
Aug 15, 2017
7e11bad
Android: Improve getCurrentPosition API
rigdern Aug 15, 2017
274f10f
Expose "register devtools plugin" interface globally in React-Native
Slava Aug 15, 2017
a7468a4
Introducing smart `RCTUnsafeExecuteOnMainQueueOnceSync()` and fixed `…
shergin Aug 15, 2017
eb01f8f
Revert D4449255: [react-native][PR] Fixed ART Surface initialization:…
shergin Aug 16, 2017
c2b3ee7
Do not send 'hot' parameter when requesting a bundle from Android
rafeca Aug 16, 2017
d0669fc
`onAnimatedValueUpdate` should also include offset
rozele Aug 16, 2017
fedc002
Use offset adjusted value in ModulusAnimatedNode
rozele Aug 16, 2017
aaae99e
metro-bundler: transform import() to basic require()
Aug 16, 2017
6ad7e82
Do not send 'hot' parameter when requesting a bundle from iOS
rafeca Aug 16, 2017
da9e51c
Docs component grid laid out with CSS Grid
JodiWarren Aug 16, 2017
9c2a5cd
Update documentation for PermissionsAndroid
conanak99 Aug 16, 2017
dc61f10
Make ResourceDrawableIdHelper work with resource id
sriramramani Aug 16, 2017
f69638b
Fix Unexpected token ) in babel-preset-react-native
charpeni Aug 16, 2017
9e71b60
Make prospective syntax compatible
jaychsu Aug 16, 2017
1cc7ae2
FBASSERT -> FBJNI_ASSERT, ALOGE -> FBJNI_LOGE, ALOGF -> FBJNI_LOGF
mhorowitz Aug 17, 2017
40a2885
android: allow whitelisting urls to bypass default webview loading
fkgozali Aug 17, 2017
381f738
Updated troubleshooting - changing port section
G2Jose Aug 17, 2017
2c076cd
Flag large pull requests, add large-pr command
hramos Aug 17, 2017
cdf1b0e
Note about flex
petrbela Aug 17, 2017
bb98fdd
Add documentation on .focus and .blur
tomasreimers Aug 17, 2017
30d9c3d
Add suppressions for Flow v0.53.0 before React changes
Aug 17, 2017
c080fe5
add perf markers for reload and download
bnham Aug 17, 2017
3c12faf
Restore correct placement of PRE_RUN_JS_BUNDLE_START
Aug 17, 2017
caaf7fd
Add more perf counters
alexeylang Aug 17, 2017
904e77a
fix content appeared logging pt2
bnham Aug 17, 2017
14e67a3
Fix dev support calls made without an ifdef guard
pakoito Aug 17, 2017
0d3039f
Fix for Modal behavior when menu button pressed on Apple TV (Issue #1…
Aug 17, 2017
f95153e
Loading-State when reloading Android WebView
DracoBlue Aug 17, 2017
36f2d18
Disallow trailing commas in react-native-github
elicwhite Aug 17, 2017
1ce7e4c
add notifications for dev reload
bnham Aug 18, 2017
90eaeb0
Upgrade fbsource/xplat/js to Flow v0.53.0
Aug 18, 2017
609ee65
Remove request dependency from core directory
Aug 18, 2017
2b7cb46
iOS: Fix registration for UIContentSizeCategoryDidChangeNotification
rigdern Aug 18, 2017
04c2f55
Update to [email protected]
zertosh Aug 18, 2017
809f1e9
Avoid race condition for AppState.currentState
rozele Aug 18, 2017
2292023
Link to main Android NDK website
radko93 Aug 18, 2017
f6de2e4
Don't assume JS integers are dynamic Ints
mhorowitz Aug 18, 2017
9f5bdd7
Size height of Android Text component based on includeFontPadding style
mgreenberg75 Aug 18, 2017
62a4912
Add Skype to showcase
hramos Aug 19, 2017
ffbd3db
Android WebView: Only fire onLoadStart for toplevel page loads
rigdern Aug 19, 2017
db225c1
Fix button spacing and layout on small screens
Aug 19, 2017
a777517
Update GettingStarted.md
Aug 19, 2017
992777b
Pass minTimeLeftInFrameForNonBatchedOperationMs from above
alexeylang Aug 21, 2017
67c160c
BREAKING: Change aspect ratio behavior
Aug 21, 2017
606a876
Kill JSCConfig
Aug 21, 2017
73f1790
Make JavaScriptExecutor.Factory a configurable property of ReactInsta…
Aug 21, 2017
c3b47e5
Remove appcompat dep from react/views/toolbar
ayc1 Aug 21, 2017
5cdf5f3
Use proper script way to clone Emoji files from www
nmn Aug 21, 2017
f0d9810
Reduce possible race condition on gc of catalyst instance
Aug 22, 2017
e063453
react-native: release new babel-preset version
Aug 22, 2017
4aae843
Report perf counters always when we call flushPendingBatches()
alexeylang Aug 22, 2017
0a4085b
RN local-cli: format and @flow filterPlatformAssetScales
Aug 22, 2017
f0f25c5
Make gYGNodeDefaults const
swolchok Aug 22, 2017
950c2b2
ScrollView: `contentOffset` validatation now respects `contentInset`
shergin Aug 22, 2017
5590b1b
Split up AnimatedImplementation.js
janicduplessis Aug 23, 2017
743dc20
Fixed issue with path containing spaces
gabrielbull Aug 23, 2017
ad4aee7
Return meaningful error when no devices available
vladimir-kotikov Aug 23, 2017
9c2caaa
Expose method to set custom baseline function
rsreejithkrishnan Aug 23, 2017
95faccb
Fix const declaration mismatch and double/float mix
woehrl01 Aug 23, 2017
dc79269
Add @providesModule annotation to Animated files
rafeca Aug 23, 2017
2172bb4
Revert "Add a new babel transformer for inlining regenerator-runtime …
matt-oakes Aug 23, 2017
68664ac
Fix stylesheet registery
sahrens Aug 23, 2017
22d283b
Update flow-bin in package.json to ^0.53.0 (to match .flowconfig)
fmoo Aug 23, 2017
28c1c88
Adjust row height by font size in PickerIOS
alin23 Aug 24, 2017
e6ff0da
fix and enrich Vibration docs
ivan-ha Aug 24, 2017
6493a85
RCTShadowView have got `rootView` property
shergin Aug 24, 2017
b6e0f4a
RN local-cli: fix saveAsset scales filtering
Aug 24, 2017
79fdb91
Fix HMR when adding/renaming assets
rafeca Aug 24, 2017
f266ab9
Move cleanup back to destructor
Aug 24, 2017
0b17524
Metro HMR: Add file parameter to getShallowDependencies()
rafeca Aug 24, 2017
edf60ce
Fix ENABLE_INSPECTOR ifdef not found during dev
pakoito Aug 24, 2017
58786ac
Update icebox message
hramos Aug 24, 2017
4908e39
New guide: Improving User Experience
frantic Aug 24, 2017
79e498b
Allow packager to be opened in specific terminal on Linux and Mac OS X
smvv Aug 24, 2017
728313c
Update CODEOWNERS
hramos Aug 24, 2017
91417ae
Mention correct shortcut to open "Developer Tools"
koenpunt Aug 25, 2017
b48149e
Expose barStyle for NavigatorIOS and TabBarIOS
jacobp100 Aug 25, 2017
99b11ea
Delete empty file
javache Aug 25, 2017
b050b69
BREAKING: iOS: Fix case sensitivity build warning in Xcode 8.3
Aug 25, 2017
dacb1fb
Increase RCTTestRunner timeouts
javache Aug 25, 2017
84b11dd
Add Android React Native Checkbox
Aug 25, 2017
128a856
fix missing @providesModule
kassens Aug 25, 2017
4535d52
Fix Yoga podspec casing
javache Aug 25, 2017
db39d23
Remove v4 dependency from Catalyst + RN libraries
Aug 25, 2017
26ef0b0
Add Troubleshooting Guide to Sidebar.
hramos Aug 25, 2017
5d58831
revert D5609280
aaronechiu Aug 26, 2017
dc22bd6
Add fb4a native modules to snapshot tests
sahrens Aug 26, 2017
1a262a7
Fix panResponder nativeEvent.locationX and locationY values on touch …
newyankeecodeshop Aug 28, 2017
2ceed95
Support flash scroll indicators for android
AlanFoster Aug 28, 2017
94a2ff9
Force original ime option when using multiline with blurOnSubmit in a…
reneweb Aug 28, 2017
6846149
iOS: Warn about slow main thread React methods
Aug 29, 2017
b8d347d
Update AnimatedImplementation.js
alexdar94 Aug 29, 2017
46f0a3b
Disambiguate error messages in MethodCall
javache Aug 29, 2017
6b7f10d
iOS: Geolocation: Allow skipping of permission prompts
Aug 29, 2017
7542f3d
Call reloadImage less often when setting Image props
javache Aug 29, 2017
7d0c128
Remove 'Debug JS on-device (experimental)' feature
Hypuk Aug 29, 2017
b11656a
Update _flowconfig
javache Aug 29, 2017
bf67345
Expose webSocketDidOpen in RCTReconnectingWebSocket
cpluss Aug 29, 2017
2d0fe10
Fix Prettier
elicwhite Aug 29, 2017
63f9901
Fix React Native open source
Aug 29, 2017
ccc11f2
Fix Image.getSize() according to image orientation
doochik Aug 30, 2017
e9d7711
add debug overlay
aaronechiu Aug 30, 2017
c68bb6a
Update systrace markers
javache Aug 30, 2017
d63cf13
download bundle atomically
bnham Aug 30, 2017
ce4e41a
fix content appeared logging
bnham Aug 30, 2017
b7096c1
fix logging of tagged markers
bnham Aug 30, 2017
abe7a2a
encapsulate JS source in RCTSource object
bnham Aug 30, 2017
a643927
Fix flow types of getShallowDependencies()
rafeca Aug 30, 2017
1f9fc0e
Stop CxxBridge run loop when bridge is invalidated
Aug 30, 2017
dd92dba
Turn on Flow for EventEmitter
elicwhite Aug 30, 2017
de01f09
Remove the restriction on importing bridge:cxxreact
mhorowitz Aug 30, 2017
fe0d081
Remove v4 support library from RN deps
Aug 30, 2017
42713c9
Fix empty @ReactModuleList generated code
Aug 30, 2017
2b86aba
Add "- React Native" to all pages title in doc section
gabrielglvr Aug 30, 2017
9f38d45
Create 2017-08-28-react-native-monthly-3.md
grabbou Aug 31, 2017
a646743
Alert - allow for hiding alert title on iOS
Aug 31, 2017
6ceb4fa
add files changed count to reload metrics
bnham Aug 31, 2017
259161f
add files changed count to reload metrics
bnham Aug 31, 2017
9399379
Gracefully handle any unrecognized stack frame format
adamjernst Aug 31, 2017
5d7934a
Updated TextInput prop doc
haani104 Aug 31, 2017
c5beb7f
Add radko93 to GitHub Issue task force
radko93 Aug 31, 2017
3388467
metro-bundler: v0.12
Aug 31, 2017
8b9df81
Provide example of android side implementation of HeadlessJS
Aug 31, 2017
6763f7a
Revert D5724764: [react-native][PR] iOS: Warn about slow main thread …
jingc Aug 31, 2017
47c8b07
add ability to print from JS and app navigation as a category
aaronechiu Aug 31, 2017
2feb74d
fixed image in RNTester snapshot example
fkgozali Aug 31, 2017
bf80585
Switch to xplat folly
mzlee Aug 31, 2017
3ab973e
metro-bundler: v0.13
Sep 1, 2017
77c11e8
RCTManagedPointer fix ups
fromcelticpark Sep 1, 2017
d82138f
[0.49.0-rc.0] Bump version numbers
grabbou Sep 1, 2017
031feb6
Update IntegrationWithExistingApps.md
hramos Sep 5, 2017
29e5deb
Fix scroll events getting skipped on Android
janicduplessis Sep 2, 2017
0a31997
fix fontWeight regression
nihgwu Sep 7, 2017
aa0b2ad
Fix unrecognized selector error
giladno Sep 4, 2017
f65b9e8
Change intValue -> integerValue in RCTMultipartStreamReader
ide Sep 5, 2017
d188865
[0.49.0-rc.1] Bump version numbers
ide Sep 7, 2017
80e8efe
Comment out Flow tests
hramos Sep 8, 2017
0fea351
Comment out failing buck install command
hramos Sep 5, 2017
897a3a5
[0.49.0-rc.2] Bump version numbers
grabbou Sep 8, 2017
af3e1d4
Improve RCTCxxBridge invalidation
javache Sep 11, 2017
dff572c
[0.49.0-rc.3] Bump version numbers
ide Sep 11, 2017
6b39d64
Android Oreo (8.0) Support
AndrewJack Sep 11, 2017
5d95e99
Refactor how symlinks are discovered in local-cli, support scoped mod…
Sep 14, 2017
6d64892
Fix crash when trying to load photo library assets with nil image url
terribleben Sep 14, 2017
a41995f
[0.49.0-rc.4] Bump version numbers
ide Sep 14, 2017
1f85e21
Add BlobModule native module mock to jest setup
Sep 7, 2017
ac4a214
[0.49.0-rc.5] Bump version numbers
ide Sep 19, 2017
776bd34
Validate that JS and Native code versions match for RN releases
janicduplessis Sep 28, 2017
af89654
[0.49.0-rc.6] Bump version numbers
ide Sep 28, 2017
35717c7
[0.49.0] Bump version numbers
grabbou Oct 3, 2017
6f23242
Set fishhook's header_dir to "fishhook"
ide Oct 4, 2017
cd81eff
[0.49.1] Bump version numbers
ide Oct 4, 2017
45a4827
Fix Flow errors in ListViewData source.
nmn Sep 19, 2017
7b7b491
[0.49.2] Bump version numbers
ide Oct 7, 2017
4cb4a71
Fixed runtime error with ProgressBarAndroid
Sep 19, 2017
afdd0d5
[0.49.3] Bump version numbers
ide Oct 9, 2017
dd63cbf
Add a check in InitializeCore.js that PlatformConstants native module…
fromcelticpark Oct 3, 2017
4555b06
Fix broken releases script
grabbou Oct 12, 2017
ee68b11
[0.49.4] Bump version numbers
grabbou Oct 13, 2017
a115c6a
medias -> media. get duration and width/height
kesha-antonov Oct 15, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 4 additions & 2 deletions .buckconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
[android]
target = Google Inc.:Google APIs:23

[download]
max_number_of_retries = 3

[maven_repositories]
central = https://repo1.maven.org/maven2

[alias]
movies = //Examples/Movies/android/app:app
uiexplorer = //Examples/UIExplorer/android/app:app
rntester = //RNTester/android/app:app
11 changes: 10 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,13 @@
**/staticBundle.js
**/main.js
Libraries/vendor/**/*
packager/src/worker-farm/**/*
Libraries/Renderer/*
website/node_modules
pr-inactivity-bookmarklet.js
question-bookmarklet.js
flow/
website/core/metadata.js
website/core/metadata-blog.js
website/src/react-native/docs/
website/src/react-native/blog/
danger/
55 changes: 29 additions & 26 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
"root": true,

"parser": "babel-eslint",

"ecmaFeatures": {
Expand All @@ -11,6 +13,8 @@
},

"plugins": [
"flowtype",
"prettier",
"react"
],

Expand Down Expand Up @@ -49,34 +53,28 @@
"setTimeout": false,
"window": false,
"XMLHttpRequest": false,
"pit": false,

// Flow global types.
"ReactComponent": false,
"ReactClass": false,
"ReactElement": false,
"ReactPropsCheckType": false,
"ReactPropsChainableTypeChecker": false,
"ReactPropTypes": false,
"SyntheticEvent": false,
"$Either": false,
"$All": false,
"$ArrayBufferView": false,
"$Tuple": false,
"$Supertype": false,
"$Subtype": false,
"$Shape": false,
"$Diff": false,
"$Keys": false,
"$Enum": false,
"$Exports": false,
"$FlowIssue": false,
"$FlowFixMe": false,
"$FixMe": false
"pit": false
},

"rules": {
"comma-dangle": 0, // disallow trailing commas in object literals
// Flow Plugin
// The following rules are made available via `eslint-plugin-flowtype`
"flowtype/define-flow-type": 1,
"flowtype/use-flow-type": 1,

// General

// This must be disallowed in this repo because the minimum supported
// version of node is 4 which doesn't support trailing commas.
// Once the minimum supported version is 8 or greater this can be changed
"comma-dangle": [2, { // disallow trailing commas in object literals
"arrays": "ignore",
"objects": "ignore",
"imports": "ignore",
"exports": "ignore",
"functions": "never"
}],

"no-cond-assign": 1, // disallow assignment in conditional expressions
"no-console": 0, // disallow use of console (off by default in the node environment)
"no-const-assign": 2, // disallow assignment to const-declared variables
Expand Down Expand Up @@ -176,6 +174,10 @@
"no-restricted-modules": 1, // restrict usage of specified node modules (off by default)
"no-sync": 0, // disallow use of synchronous methods (off by default)

// Prettier Plugin
// https://github.com/prettier/eslint-plugin-prettier
"prettier/prettier": [2, "fb", "@format"],

// Stylistic Issues
// These rules are purely matters of style and are quite subjective.

Expand Down Expand Up @@ -228,6 +230,7 @@

"react/display-name": 0,
"react/jsx-boolean-value": 0,
"react/jsx-no-comment-textnodes": 1,
"react/jsx-no-duplicate-props": 2,
"react/jsx-no-undef": 1,
"react/jsx-sort-props": 0,
Expand All @@ -241,6 +244,6 @@
"react/prop-types": 0,
"react/react-in-jsx-scope": 1,
"react/self-closing-comp": 1,
"react/wrap-multilines": 0,
"react/wrap-multilines": 0
}
}
17 changes: 11 additions & 6 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
; Ignore the website subdir
<PROJECT_ROOT>/website/.*

; Ignore the Dangerfile
<PROJECT_ROOT>/danger/dangerfile.js

; Ignore "BUCK" generated dirs
<PROJECT_ROOT>/\.buckd/

Expand All @@ -18,7 +21,9 @@
; For RN Apps installed via npm, "Libraries" folder is inside
; "node_modules/react-native" but in the source repo it is in the root
.*/Libraries/react-native/React.js
.*/Libraries/react-native/ReactNative.js

; Ignore polyfills
.*/Libraries/polyfills/.*

[include]

Expand All @@ -31,22 +36,22 @@ emoji=true

module.system=haste

experimental.strict_type_args=true

munge_underscores=true

module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'

suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FlowFixMeProps
suppress_type=$FlowFixMeState
suppress_type=$FixMe

suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-5]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-5]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-3]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-3]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError

unsafe.enable_getters_and_setters=true

[version]
^0.45.0
^0.53.0
18 changes: 18 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
docs/* @hramos
blog/* @hramos
Libraries/Animated/* @janicduplessis
Libraries/NativeAnimation/* @janicduplessis
Libraries/Image/* @shergin
Libraries/Text/* @shergin
React/Base/* @shergin
React/Views/* @shergin
React/Modules/* @shergin
React/CxxBridge/* @mhorowitz
ReactAndroid/src/main/java/com/facebook/react/animated/* @janicduplessis
website/* @hramos
website/showcase.json @hramos
package.json @hramos
website/package.json @hramos
local-cli/core/* @grabbou @kureev
local-cli/link/* @grabbou @kureev
local-cli/unlink/* @grabbou @kureev
126 changes: 104 additions & 22 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,118 @@
Please read the following carefully before opening a new issue.
Your issue may be closed if it does not provide the information required by this template.
<!--
PLEASE DON'T DELETE THIS TEMPLATE UNTIL YOU HAVE READ THE FIRST SECTION.
-->

We use GitHub Issues exclusively for tracking bugs in React Native.
### Is this a bug report?

- If you have a question, ask on Stack Overflow: http://stackoverflow.com/questions/tagged/react-native
- If you have a feature request, post it on Canny: https://react-native.canny.io/feature-requests
(write your answer here)

Make sure your issue reproduces on master. Your issue may already have been fixed!
If your issue is present in master and in the stable release, try to reproduce your bug on https://snack.expo.io/
If you can't reproduce the bug on Snack, provide a sample project.
At the very least, provide an example of your code.
<!--
If you answered "Yes":

--- Delete everything above this line ---
We expect that it will take you about 30 minutes to produce a high-quality bug report.
While this may seem like a lot, putting care into issues helps us fix them faster.
For bug reports, it is REQUIRED to fill the rest of this template, or the issue will be closed.

### Description
If you answered "No":

Explain what you did, what you expected to happen, and what actually happens.
We use GitHub Issues exclusively for tracking bugs in React Native. If you're looking for help,
the Community page at http://facebook.github.io/react-native/support.html list various resources
that should help you get started.

### Reproduction Steps and Sample Code
Now scroll below!
-->

List all the steps required to reproduce the issue you're reporting. These steps should be clear and concise.
### Have you read the [Contributing Guidelines](https://facebook.github.io/react-native/docs/contributing.html)?

***An example of your code is REQUIRED***
(Write your answer here.)

### Environment

### Solution
<!--
Please fill in all the relevant fields by running these commands in terminal.
-->

What needs to be done to address this issue? Ideally, provide a pull request with a fix.
1. `react-native -v`:
2. `node -v`:
3. `npm -v`:
4. `yarn --version`<!-- (if you use Yarn) -->:

### Additional Information
Then, specify:

* React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
* Platform: [FILL THIS OUT: iOS, Android, or both?]
* Development Operating System: [FILL THIS OUT: Are you developing on MacOS, Linux, or Windows?]
* Dev tools: [FILL THIS OUT: Xcode or Android Studio version, iOS or Android SDK version, if applicable]
<!-- (What platform are you building for? Choose any from iOS, Android, AppleTV.) -->
- Target Platform:

<!-- Which operating system are you using? Specify macOS, Windows, or Linux, along with specific release versions -->
- Development Operating System:

<!-- Include any additional relevant information. Are you using Xcode or Android Studio to build native code? Is the issue specific to a particular iOS or Android SDK? -->
- Build tools:

### Steps to Reproduce

<!--
How would you describe your issue to someone who doesn’t know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
Be specific! If the bug cannot be reproduced, your issue may be closed.
-->

(Write your steps here:)

1.
2.
3.

### Expected Behavior

<!--
How did you expect your project to behave?
It’s fine if you’re not sure your understanding is correct.
Just write down what you thought would happen.
-->

(Write what you thought would happen.)

### Actual Behavior

<!--
Did something go wrong?
Is something broken, or not behaving as you expected?
Describe this section in detail, and attach screenshots if possible.
Don't just say "it doesn't work"!
-->

(Write what happened. Add screenshots!)

### Reproducible Demo

<!--
Please share a project that reproduces the issue.
There are two ways to do it:

* Create a new app using https://snack.expo.io/ and try to reproduce the issue in it.
This is useful if you roughly know where the problem is, or can’t share the real code.

* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
This is useful for finding the root cause. You may then optionally create a Snack.

This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
Once you’re done, copy and paste the link to the Snack or a public GitHub repository below:
-->

(Paste the link to an example project and exact instructions to reproduce the issue.)

<!--
What happens if you skip this step?

Someone will read your bug report, and maybe will be able to help you,
but it’s unlikely that it will get much attention from the team. Eventually,
the issue will likely get closed in favor of issues that have reproducible demos.

Please remember that:

* Issues without reproducible demos have a very low priority.
* The person fixing the bug would have to do that anyway. Please be respectful of their time.
* You might figure out the issues yourself as you work on extracting it.

Thanks for helping us help you!
-->
34 changes: 9 additions & 25 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,16 @@
Thanks for submitting a PR! Please read these instructions carefully:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

- [ ] Explain the **motivation** for making this change.
- [ ] Provide a **test plan** demonstrating that the code is solid.
- [ ] Match the **code formatting** of the rest of the codebase.
- [ ] Target the `master` branch, NOT a "stable" branch.
Help us understand your motivation by explaining why you decided to make this change.

## Motivation (required)
You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

What existing problem does the pull request solve?
Happy contributing!

## Test Plan (required)
-->

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.
(Write your motivation here.)

If you have added code that should be tested, add tests.
## Test Plan

## Next Steps

Sign the [CLA][2], if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.

For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines.

[1]: https://medium.com/@martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9
[2]: https://code.facebook.com/cla
[3]: https://travis-ci.org/facebook/react-native
[4]: http://circleci.com/gh/facebook/react-native
[5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
9 changes: 5 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ project.xcworkspace

# Gradle
/build/
/Examples/**/android/app/build/
/Examples/**/android/app/gradle/
/Examples/**/android/app/gradlew
/Examples/**/android/app/gradlew.bat
/RNTester/android/app/build/
/RNTester/android/app/gradle/
/RNTester/android/app/gradlew
/RNTester/android/app/gradlew.bat
/ReactAndroid/build/

# Buck
Expand All @@ -47,6 +47,7 @@ local.properties
node_modules
*.log
.nvm
/danger/node_modules/

# OS X
.DS_Store
Expand Down
Loading