Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup stale port docs #13687

Closed
wants to merge 1 commit into from
Closed

Cleanup stale port docs #13687

wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Apr 27, 2017

The option to change a port is no longer displayed in the dev menu.
We don't need to call out specific apps that use port 8081.
People can now use React DevTools to debug on Chrome.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Apr 27, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@gaearon
Copy link
Collaborator

gaearon commented Apr 29, 2017

People can now use React DevTools to debug on Chrome.

This is not exactly right. They can do so — but not from the Chrome extension.

thotegowda pushed a commit to thotegowda/react-native that referenced this pull request May 7, 2017
Summary:
The option to change a port is no longer displayed in the dev menu.
We don't need to call out specific apps that use port 8081.
People can now use React DevTools to debug on Chrome.
Closes facebook#13687

Differential Revision: D4962385

Pulled By: hramos

fbshipit-source-id: ddf491e8091b5c6443ab3ca080cae5253268c6d7
facebook-github-bot pushed a commit that referenced this pull request Oct 13, 2018
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
kelset pushed a commit that referenced this pull request Nov 9, 2018
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (facebook#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (facebook#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (facebook#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (facebook#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (facebook#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (facebook#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (facebook#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (facebook#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (facebook#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (facebook#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants