[WIP] Use SnackPlayer for API/Component examples #13646
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring the possibility of rendering embedded Snack players for each of the examples in the API/Components docs. It works for some components such as
ViewPagerAndroid
(with warnings), but many other examples fail to load due to the expectation these will be running inside theUIExplorer
app.ViewPagerAndroid
This example works pretty well inside the Snack Player:
Warnings
These can be solved by updating all of our examples to use imports.
...but we will also need to update the examples to export a class by default:
StatusBar
Some examples such as
StatusBarExample.js
won't load due to the way they export multiple possible examples for use in theUIExplorer
app.AlertIOS
These
require()
s break the example in Snack:See also export warnings.
Next Steps
UIExplorer
app as well as in the Snack Player? Or should we decouple these examples from theUIExplorer
?