PushNotificationIOS.requestPermissions won't resolve if no event listeners are attached #13263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
peterp
force-pushed
the
issue-13012-push-notification-ios-request-permissions
branch
2 times, most recently
from
dbb3cca to
dff2a98
Compare
|
cc @frantic, does this fix make sense? |
peterp
force-pushed
the
issue-13012-push-notification-ios-request-permissions
branch
from
dff2a98 to
b2398f8
Compare
frantic
reviewed
Apr 3, 2017
| @@ -249,6 +269,7 @@ - (void)handleRemoteNotificationReceived:(NSNotification *)notification | |||
| - (void)handleRemoteNotificationsRegistered:(NSNotification *)notification | |||
| { | |||
| [self sendEventWithName:@"remoteNotificationsRegistered" body:notification.userInfo]; | |||
| [self stopObservingRegisteredNotifications]; | |||
There was a problem hiding this comment.
Why do you need to stopObservingRegisteredNotifications? IIRC when registering for push (not local) notifications, RCTRegisterUserNotificationSettings is called first, followed by RCTRemoteNotificationsRegistered if we got push token.
I don't see a reason to stop observing because it adds complexity without much gain.
|
It's clean and awesome, thanks @peterp! My only suggestion is to not manually unsubscribe from notification center, because it might introduce some racing bugs. |
peterp
force-pushed
the
issue-13012-push-notification-ios-request-permissions
branch
from
b2398f8 to
07a6afb
Compare
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
peterp
force-pushed
the
issue-13012-push-notification-ios-request-permissions
branch
from
07a6afb to
9796f57
Compare
peterp
force-pushed
the
issue-13012-push-notification-ios-request-permissions
branch
from
9796f57 to
fc2c7eb
Compare
|
Nice to see this issue get some attention! Cheers gents. |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
…eners are attached Summary: Resolves facebook#13012 RCTPushNotificationManager uses startObserving to register for RCTRegisterUserNotificationSettings. According to the docs, the startObserving method won't be called until somebody subscribes to NotificationManagerIOS. This means there is a scenario when the developer can call requestPermissions without subscribing to notifications first, but since RCTPushNotificationManager relies on NSNotificationCenter subscribtion, the result will never be returned. When requesting permissions the promise will resolve: `PushNotificationIOS.requestPermissions().then(console.log);` without the need for calling `PushNotificationIOS.addEventListener()` first. Closes facebook#13263 Differential Revision: D4851767 Pulled By: javache fbshipit-source-id: 2be8621e072ae1086014594bc986ca5590b5eb61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #13012
RCTPushNotificationManager uses startObserving to register for RCTRegisterUserNotificationSettings. According to the docs, the startObserving method won't be called until somebody subscribes to NotificationManagerIOS.
This means there is a scenario when the developer can call requestPermissions without subscribing to notifications first, but since RCTPushNotificationManager relies on NSNotificationCenter subscribtion, the result will never be returned.
Test Plan
When requesting permissions the promise will resolve:
PushNotificationIOS.requestPermissions().then(console.log);without the need for callingPushNotificationIOS.addEventListener()first.