-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copy button work on android emulator in Linux using xsel #13188
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Can you place the |
@hramos I renamed the folder as you requested. |
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
Summary: Resolves issue [facebook#13165](facebook#13165). The copy button in the redbox for RN android is not currently supported for Linux. This pull request provides the copy button functionality to Linux RN users. I have tested the updated code locally. Firstly, I edited `index.android.js` that caused the following error.  After I clicked the copy button and pasted from the clipboard into the chrome address bar, the message appeared.  Closes facebook#13188 Differential Revision: D4819796 Pulled By: ericvicenti fbshipit-source-id: 9adc6e93330f89240a505a403e4913dc10e5a31f
Summary: Resolves issue [#13165](facebook/react-native#13165). The copy button in the redbox for RN android is not currently supported for Linux. This pull request provides the copy button functionality to Linux RN users. I have tested the updated code locally. Firstly, I edited `index.android.js` that caused the following error.  After I clicked the copy button and pasted from the clipboard into the chrome address bar, the message appeared.  Closes facebook/react-native#13188 Differential Revision: D4819796 Pulled By: ericvicenti fbshipit-source-id: 9adc6e93330f89240a505a403e4913dc10e5a31f
Motivation (required)
Resolves issue #13165. The copy button in the redbox for RN android is not currently supported for Linux. This pull request provides the copy button functionality to Linux RN users.
Test Plan (required)
I have tested the updated code locally.


Firstly, I edited
index.android.js
that caused the following error.After I clicked the copy button and pasted from the clipboard into the chrome address bar, the message appeared.