[Packager] Auto populate remote packager in info.plist #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ghost
mentioned this pull request
|
🆒 ! Seems pretty easy. Could you please extract it into a shell script and then call it from Xcode? This way it's easier to test and review. |
|
@tobyhughes - are you still interested in working on this? |
brentvatne
changed the title
|
@rebeccahughes Any updates on this? |
|
@rebeccahughes updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Closing this. Let's reopen if you are interested to work on this again. |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature suggested by @frantic in #548. Adds a run script build phase to the Xcode project that automatically populates the
ReactServervalue in theinfo.plistfile so that remote debugging "just works". It only populates the value if the user is building anarmv*binary in debug mode so you won't accidentally populate the value when do a release build.