-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FlatList doc #12714
Update FlatList doc #12714
Conversation
Mention scrollToIndex support. Fix a format error.
use relative links like https://github.com/facebook/react-native/blob/59257d6976656f4eeaf389ae5527dfaff08e7354/Libraries/Components/Navigation/NavigatorIOS.ios.js#L136 for links in "next version" to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can accept the simple doc fixes ASAP, but the renaming of columnWrapperStyle
is a breaking change and needs to be manually imported by a FB employee. Can you rename this PR to document the breaking change?
cc @sahrens, Based on the way it is used, it certainly seems that rowWrapperStyle
is a better name. Do you agree, or should we fix up the doc to explain it better?
ping @sahrens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was that a "columnWrapper" makes a row that wraps the columns. It also makes it more obvious it's related to columns, "rowWrapper" sounds like something that would work even if numColumns=1
So....how about |
Hmm, if folks think |
Or maybe |
Well, I am not a native speaker, so I think I should leave this weird naming problem to you guys. |
@facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc fixes!
@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
react-native/Libraries/Components/Navigation/NavigatorIOS.ios.js
Line 136 in 59257d6
4. BREAKING:columnWrapperStyle
should berowWrapperStyle
?