Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS ONLY: Update breaking changes location in breaking-changes.md: move to Wiki #12184

Closed
wants to merge 1 commit into from

Conversation

xml
Copy link
Contributor

@xml xml commented Feb 3, 2017

Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@xml
Copy link
Contributor Author

xml commented Feb 3, 2017

CLA complete.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2017
@mkonicek
Copy link
Contributor

mkonicek commented Feb 3, 2017

Good catch, thanks! Deleting the file might be even simpler :)

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Feb 3, 2017
@facebook-github-bot
Copy link
Contributor

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

edmofro pushed a commit to edmofro/react-native that referenced this pull request Feb 6, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 7, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
normanjoyner pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
GaborWnuk pushed a commit to GaborWnuk/react-native that referenced this pull request Feb 28, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
maarf pushed a commit to fullcontact/react-native that referenced this pull request Apr 26, 2017
…ove to Wiki

Summary:
Also, remove ancient breaking changes details from 0.16 and before, as they only confused and distracted attention from the importance of seeking the information elsewhere.
Closes facebook#12184

Differential Revision: D4507539

Pulled By: mkonicek

fbshipit-source-id: 9d0f274ac7e3141c9b535d3b156e98e1cf3659d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants