Updated Systrace and RCTRenderingPerf to sync w/ React changes #11970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @davidaurelio and @gaearon to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
lgtm (just hit the |
facebook-github-bot
added
the
Import Started
|
@bvaughn has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
A temporary React Native compatibility fix was added to React in commit bba0d992d8f4ecf9cf6677817a1218e7f48a8a77 and subsequently removed in commit e612826650ff68e73bff4d71db01fea8147ee1fd. This commit updates React Native to no longer rely on the deprecated method+module.
bvaughn
force-pushed
the
update-react-debug-tool-method-names
branch
from
ac700bc to
962618d
Compare
facebook-github-bot
added
the
Import Started
|
@bvaughn has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
|
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: A temporary React Native compatibility fix was added to React in commit [bba0d99](facebook/react@bba0d99) and subsequently removed in commit [e612826](facebook/react@e612826). I noticed this while testing the React Native fiber renderer and attempting to use `Systrace`. This commit updates React Native to no longer rely on the deprecated method and module. PS I'm not sure if I should also update `ReactDebugTool` with this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄 Closes facebook#11970 Differential Revision: D4446219 Pulled By: bvaughn fbshipit-source-id: f286b8a4d00cdcbfbb49f52b9f1db5231d453f4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary React Native compatibility fix was added to React in commit bba0d99 and subsequently removed in commit e612826. I noticed this while testing the React Native fiber renderer and attempting to use
Systrace.This commit updates React Native to no longer rely on the deprecated method and module.
PS I'm not sure if I should also update
ReactDebugToolwith this commit or wait for a subsequent sync script to update it. I haven't committed to this repo before. Please advise. 😄