Add symlinks under node_modules as part of projectRoots #11810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grabbou and @aleclarson to be potential reviewers. |
facebook-github-bot
added
CLA Signed
Kureev
reviewed
Jan 30, 2017
| @@ -22,6 +22,9 @@ const windows = require('./windows'); | |||
| const wrapCommands = require('./wrapCommands'); | |||
| const findPlugins = require('./findPlugins'); | |||
|
|
|||
| const findSymlinksPaths = require('../util/findSymlinksPaths'); | |||
There was a problem hiding this comment.
AFAIK it's ../server/findSymlinksPaths
There was a problem hiding this comment.
Can you please double-check if your code works, @harshil07?
There was a problem hiding this comment.
it does work @Kureev . i moved the file to util as part of this PR given it was being used outside of "server" code.
There was a problem hiding this comment.
Ah, I see. Missed this line
|
@facebook-github-bot shipit |
|
@Kureev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
Kureev
reviewed
Feb 17, 2017
| args.projectRoots = roots.concat( | ||
| findSymlinksPaths(NODE_MODULES, roots) | ||
| ); | ||
| args.projectRoots.concat(args.root); |
There was a problem hiding this comment.
woah, how could I miss that
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Support symlinks under `node_modules` for all local-cli commands. PR facebook/react-native#9009 only adds symlink support to the packager. But other cli commands like `react-native bundle` creates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked. This change ensures all `local-cli` commands add symlinks to its project roots. Test plan (required) 1. Create a symlink in node_modules (for instance use npm/yarn link) 2. Run `react-native bundle`. Closes facebook/react-native#11810 Differential Revision: D4487741 fbshipit-source-id: 87fe44194134d086dca4eaca99ee5742d6eadb69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support symlinks under
node_modulesfor all local-cli commands. PR #9009 only adds symlink support to the packager.But other cli commands like
react-native bundlecreates its own instance of packager that doesn't have symlinks as part of its project roots, which results in the bundler breaking since it cannot find modules that you have symlinked.This change ensures all
local-clicommands add symlinks to its project roots.Test plan (required)
react-native bundle.