Resolve single flow error in node-haste #11465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ericvicenti |
|
By analyzing the blame information on this pull request, we identified @cpojer and @davidaurelio to be potential reviewers. |
|
What's the flow error? It seems like we can fix that without a FlowFixMe? |
|
Ok. I'll actually fix it. :( |
facebook-github-bot
added
the
CLA Signed
|
I just wasn't concerned with actually fixing it, since it was my impression we were moving off of node-haste in the future. :-p |
|
And was trying to fix a bug in another tangentially related project and get Flow to pass. |
|
That's a little while off. I'd prefer to fix type errors properly. |
facebook-github-bot
added
the
CLA Signed
skevy
changed the title
facebook-github-bot
added
GH Review: accepted
Import Started
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
skevy
force-pushed
the
@skevy/fix-node-haste-flow
branch
from
f9ed67f to
35bbf65
Compare
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: Makes flow pass. Closes facebook#11465 Differential Revision: D4328094 Pulled By: ericvicenti fbshipit-source-id: 5eb60831145ade00eb2d504f4958f0a683eef686
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: Makes flow pass. Closes facebook/react-native#11465 Differential Revision: D4328094 Pulled By: ericvicenti fbshipit-source-id: 5eb60831145ade00eb2d504f4958f0a683eef686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes flow pass.