Add distinction between iPhone and iPad in the interfaceOrientationWillChange method when export dimensions #11376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llChange method when export dimensions
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@adrienbataille Please see here: #11350 |
|
@manicakes Your fix looks strong mine, I'm closing my PR and hope your PR will be quickly accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to fix Dimensions not updated on iPad (#7340)
When using
let {height, width} = Dimensions.get('window');on iPhone it works fine but not on iPad.More information on the bug in this comment: #7340 (comment)