Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image component onLoadingStart/onLoadingFinish/onLoadingError props #98

Closed
jordanna opened this issue Feb 25, 2015 · 4 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jordanna
Copy link
Contributor

Not sure if this is on your radar, but I'm playing around with RCTNetworkImageView and its manager to see if I can expose them. It's mostly so I can fade in the image (vs. simply appearing) when onLoadingFinish is called, but they could be useful for other use cases :)

@vjeux
Copy link
Contributor

vjeux commented Feb 25, 2015

We have a task internally to expose those :)

@sahrens
Copy link
Contributor

sahrens commented Feb 25, 2015

Yes, please build, this would be great!

The API could be a simple prop for fadeInDuration that defaults to 0 (shows instantly), and ideally it could also call an onLoad event on the component in js for custom logic.

On Feb 25, 2015, at 12:47 AM, Christopher Chedeau [email protected] wrote:

We have a task internally to expose those :)


Reply to this email directly or view it on GitHub.

jordanna added a commit to jordanna/react-native that referenced this issue Apr 2, 2015
…age component, which are intended to provide loading states for network image sources. Updated the Image component example in the UIExplorer app to demonstrate how they can be used to fade in a network image (using the Animation API). Fixes facebook#98.
@jordanna
Copy link
Contributor Author

jordanna commented Apr 2, 2015

Just took a stab at it since I'm working on a prototype that needed the feature.

@brentvatne
Copy link
Collaborator

Closing issue as there is now a corresponding pull request 😄 (#604)

harrykiselev pushed a commit to harrykiselev/react-native that referenced this issue Aug 5, 2015
Add comma in the Doc of Todo List
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants