-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Architecture 0.76.1 not building on android #47364
Comments
yup I'm struggling from 4-5 days to find out why this happening. please fix this ASAP... |
Hi @Sanjayng125 It seems like this issue is actually unrelated to React Native core, but related to mmkv. Please open this issue against this other repository: https://github.com/mrousavy/react-native-mmkv/issues Also cc @mrousavy |
@cortinico sir the error is not only for this package. this error is occurring for every package I install... the app is building without any packages but if I install any single package this error occurs... |
Exactly @cortinico @Sanjayng125 i uninstalled every package, and tried to build it, and it worked, but once i install any package it throws in this error, i believe this issue needs to be revisited. |
I mean I'm not sure why |
@Sanjayng125 @mikey18 then can you please provide a repro that fails to build with an empty library? |
@cortinico Steps to reproduce
this is the Github Repo link |
Hey, @mikey18 reproducer.mp4I saw that your folder is |
alright i will try your fix |
i did your fix and it worked, my bad for saving my folder with white spaces. Thanks for your effort, I really appreciate a lot. |
@migueldaipre ohh thank you sir it's working for me too... so I cant use folders with whitespaces with the new arch?? |
Did this work in the old architecture? cc @cortinico |
yes it is working in old arch with whitespace. and sir one more help why it is doing slower copy saying hard link failed(in New Arch)... |
hm, hard to help you here. Please create a repro using this reproducer and send it to us if it's impacting you. |
Summary: Fixes facebook#47364 Fixes facebook#47377 Fixes facebook#37124 We're having problems is a path contains a space ' ' because when autolinking, the `add_subdirectory()` function of CMake consider the path with space as 2 parameters. This fixes it by properly quoting the path. Changelog: [Android] [Fixed] - Properly handle paths with spaces in autolinking Differential Revision: D65434413
It turns out is a problem with having a space Will be shipped in 0.76.2. In the meantime, the workaround is to don't use spaces in your full path or apply the change from the PR with |
Summary: Pull Request resolved: #47388 Fixes #47364 Fixes #47377 Fixes #37124 We're having problems is a path contains a space ' ' because when autolinking, the `add_subdirectory()` function of CMake consider the path with space as 2 parameters. This fixes it by properly quoting the path. Changelog: [Android] [Fixed] - Properly handle paths with spaces in autolinking Reviewed By: cipolleschi Differential Revision: D65434413 fbshipit-source-id: b9147482f98f7e222405cc8d9e6f3c17a5f4ed02
Hey, @cortinico When i run build on React Native 0.76.1, i have a problem and not found any whitespace in my project
What went wrong:
CMake Generate step failed. Build files cannot be regenerated correctly. |
react native setup info buildToolsVersion = "35.0.0" |
Summary: Pull Request resolved: #47388 Fixes #47364 Fixes #47377 Fixes #37124 We're having problems is a path contains a space ' ' because when autolinking, the `add_subdirectory()` function of CMake consider the path with space as 2 parameters. This fixes it by properly quoting the path. Changelog: [Android] [Fixed] - Properly handle paths with spaces in autolinking Reviewed By: cipolleschi Differential Revision: D65434413 fbshipit-source-id: b9147482f98f7e222405cc8d9e6f3c17a5f4ed02
Description
When i run build on React Native 0.76.1, i have a problem
Steps to reproduce
React Native Version
0.76.1
Affected Platforms
Runtime - Android, Build - Windows
Areas
TurboModule - The New Native Module System, Bridgeless - The New Initialization Flow, Codegen
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/mikey18/lendsqr-fp-news
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: