-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] [TextInput] Placeholder font doesn't match TextInput styling #4600
Comments
Hey turka50, thanks for reporting this issue! React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
|
I'm also having an issue with the placeholder text on Android. It does not apply the fontFamily which I have set in the styles. When I focus the TextInput the right fontFamily does get applied. |
Can confirm this. |
+1 |
Hi, |
the default fontFamily not the same when set secureTextEntry={true}. looks weird. |
I think this can be closed since it was fixed here: #6564 and will be released on 0.26 |
@facebook-github-bot close |
@charpeni tells me to close this issue. If you think it should still be opened let us know why. |
I don't know why it was closed, placeholder font style doesn't match TextInput style on Android with ReactNative 0.26.1 (iOS works fine, fontFamily is applied for placeholder as expected). |
I can repro this successfully on 0.26.1. Placeholder still has the default font. The mentioned PR applies the style to the value text, but not the placeholder text. |
I can confirm this as well. My placeholder text font doesn't match textinput font. |
I can confirm as well! Product pain opened here product-pains/TextInput-placeholder-style-customization for both iOS and Android. |
I have "react-native": "^0.25.1" and when i put |
I use the |
I am facing the same issue (aakashsigdel ) is there any workaround you get ? |
@Arwiz |
Same issue, my placeholder style doesn't match with the input style, I got this bug only on android phones. |
My TextInput text in general isn't applying the correct font family. Placeholder AND entered text. Only on Android and I'm on v0.31 |
I can also confirm this issue. React native v0.31, unable to change placeholder fontFamily on android |
Yea same here on v0.31 for Placeholder and entered text in TextInput but is fine on Buttons |
The same, if I'm trying to use custom font. |
+1, still experiencing this as well on v0.35 |
+1 |
+1 |
+1 v0.39 |
still there on 0.40 |
Please don't reply with Feel free to send a PR if you are willing to fix this. |
Refs: #12000 |
Can we have an eta on a fix for this issue? |
@janicduplessis has a PR out. I expect this to go out with RN 0.42 (Feb 1 RC, Mar 1 final release). |
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
…k#4600 Summary: When using a TextInput with a custom font, the placeholder didn't use that font. This is because ReactTextInputManager didn't use ReactFontManager to create the TypeFace which handles custom fonts. **Test plan** Tested in UI explorer by reproducing the bug with and testing that the custom font gets applied properly after the fix. ``` js <TextInput placeholder="Hello" style={{ fontFamily: 'notoserif' }} /> ``` Closes facebook#12000 Reviewed By: hramos Differential Revision: D4443713 fbshipit-source-id: e92c9822d9226681d7b00126dad95e5534c0c46e
Hi , Is it possible to set the font style of the placeholder of a text component on android ? as far as the docs go you can only change the text.
The text was updated successfully, but these errors were encountered: