Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Fetch fails with "TypeError: Network request failed" => Resolved #32931

Open
raffaeler opened this issue Jan 20, 2022 · 66 comments
Open

HTTP Fetch fails with "TypeError: Network request failed" => Resolved #32931

raffaeler opened this issue Jan 20, 2022 · 66 comments
Labels
Needs: Triage 🔍 🌐Networking Related to a networking API.

Comments

@raffaeler
Copy link

raffaeler commented Jan 20, 2022

Description

There are 83 issues opened and unanswered about network requests failing with this generic error.
The main causes of the pain are:

  1. Not getting an answer from the team
  2. The exception is far too generic and does not suggest the origin of the problem

Problem description

Using fetch to get/post on a HTTPS web server which is using a valid and trusted but not public CA.

  • Using Chrome and other apps the requests are always successful and without certificate problems

Sample code in react native:

static async Post(): Promise<string> {
    let srv = "my.domain.com";
    let port = 5101;
    let device = "abcd";
    let url = `https://${srv}:${port}/Do/Something?devicename=${device}`;

    try {
        let response = await fetch(url, {
            method: 'POST',
            headers: {
                'Accept': 'application/json',
                'Content-type':'application/json'
            },
            body: JSON.stringify({
                key: 'value',
            })
        });

        if(response.status !== 200) throw new Error(`Can't open  ${srv} for ${device} with status ${response.status}`);
        return response.json();
    }
    catch(e) {
        console.log(e);
        throw(e);
    }
}

Solution

Due to Android restrictions, a network_security_config configuration must be added to the application. It is an xml file that can be added by following these steps:

  1. Edit the android/app/src/main/AndroidManifest.xml
  2. Add the android:networkSecurityConfig="@xml/network_security_config" to the <application /> tag
  3. Create the folder android/app/src/main/res/xml and inside a file called network_security_config.xml
  4. If you don't want to install the CA in the Android certificates, add the folder android/app/src/main/res/raw

Variant 1: using the certificates added manually to Android.

In this case the CA must be visible in the User Certificates in the Android Settings. Try using them by opening a website that uses those certificates in Chrome to verify they are valid and correctly installed.

Content of the network_security_config.xml

<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
    <domain-config>
        <!-- Localhost config is NEEDED from react-native for the bundling to work  -->
        <domain-config cleartextTrafficPermitted="true">
            <domain includeSubdomains="true">127.0.0.1</domain>
            <domain includeSubdomains="true">10.0.0.1</domain>
            <domain includeSubdomains="true">localhost</domain>
        </domain-config>

        <domain includeSubdomains="true">my.domain.com</domain>
        <trust-anchors>
            <certificates src="user"/>
            <certificates src="system"/>
        </trust-anchors>
    </domain-config>
</network-security-config>

The <certificates src="user"/> is the one giving access to the certificates installed manually.

Variant 2: using a certificate bundled with the app

You should export (using ssl) a pem certificate containing just the public key, naming it "ca" (no extension). Copy the certificate in the raw folder

<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
    <domain-config>
        <!-- Localhost config is NEEDED from react-native for the bundling to work  -->
        <domain-config cleartextTrafficPermitted="true">
            <domain includeSubdomains="true">127.0.0.1</domain>
            <domain includeSubdomains="true">10.0.0.1</domain>
            <domain includeSubdomains="true">localhost</domain>
        </domain-config>

        <domain includeSubdomains="true">my.domain.com</domain>
        <trust-anchors>
            <certificates src="@raw/ca"/>
            <certificates src="system"/>
        </trust-anchors>
    </domain-config>
</network-security-config>

Important note (added on June 22, 2022)

The local traffic (with the packager) must be unencrypted. For this reason the <domain-config /> must contain the clearTrafficPermitted=true.
It is also important adding the ip addresses used from react-native when debugging otherwise the application will crash because of the android:networkSecurityConfig="@xml/network_security_config" attribute. If you see the app crashing, take not of the ip used internally from react native and add it/them to this list. For example:

<domain-config cleartextTrafficPermitted="true">
            <domain includeSubdomains="true">127.0.0.1</domain>
            <domain includeSubdomains="true">10.0.0.1</domain>
            <domain includeSubdomains="true">10.0.1.1</domain>
            <domain includeSubdomains="true">10.0.2.2</domain>
            <domain includeSubdomains="true">localhost</domain>
        </domain-config>

Requested fix: please never throw exceptions with a generic message, they are only a huge pain.

Version

0.67.0

Output of npx react-native info

info Fetching system and libraries information...
System:
OS: Windows 10 10.0.19044
CPU: (8) x64 Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
Memory: 8.20 GB / 31.93 GB
Binaries:
Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 8.1.3 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 19, 23, 25, 26, 27, 28, 29, 30
Build Tools: 19.1.0, 21.1.2, 22.0.1, 23.0.1, 23.0.3, 26.0.2, 27.0.0, 28.0.0, 28.0.3, 29.0.2, 30.0.2
System Images: android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom
Android NDK: 22.1.7171670
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
AllowAllTrustedApps: Enabled
Versions: 10.0.10586.0, 10.0.14393.0, 10.0.15063.0, 10.0.16299.0, 10.0.17134.0, 10.0.17763.0, 10.0.18362.0, 10.0.19041.0
IDEs:
Android Studio: Version 2020.3.0.0 AI-203.7717.56.2031.7935034
Visual Studio: 17.1.32104.313 (Visual Studio Enterprise 2022), 16.11.32002.261 (Visual Studio Enterprise 2019)
Languages:
Java: 1.8.0_302
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.4 => 0.66.4
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

Use the above code to make an HTTPS request to a website protected with certificates that are not public.
They will not succeed with a generic exception (as for the issue title)

Repeat the request to a public website and it will succeed.
The issue is the exception being too generic.

Snack, code example, screenshot, or link to a repository

No response

@react-native-bot react-native-bot added the 🌐Networking Related to a networking API. label Jan 20, 2022
@ariccio
Copy link

ariccio commented Feb 19, 2022

It looks like the underlying okhttp library has quite good error detection and reporting. Somehow though, either the react-native networking layer, or the whatwg-fetch doesn't capture that!

@raffaeler
Copy link
Author

It is an habit in this repo to ignore important issues (not only this one) for a very long time.
I start believing RN is not that worthy to invest in.

@hoaxvo16
Copy link

I have same issue and solve by doing this, you can try

#24627 (comment)

@raffaeler
Copy link
Author

Thank you @hoaxvo16 but I already posted the solution in this thread.
My request is react-native providing a decent error so that nobody else has to spend hours in trying to resolve it.
Also, since this an OSS project, it would be nice for some of the owner to "say something" instead of infinite silence.

@hoaxvo16
Copy link

@raffaeler yeah i know, took me over 3 hours to solve this, good thing is you learned something new :D

@amalmohann
Copy link

My issue was fixed when I restarted the emulator

@Stephnn0
Copy link

I am still having the same issue! im trying to connect my react native app to django. i am using JWT. im trying to send a post method to my api but I get "TypeError: Network request failed" => Resolved every time i press the sign in button. i am using a real android device. im new to react so it is been very hard to solve this problem! can anybody help me pls? i already try all methods above but none seem to work

@nelsonprsousa
Copy link

I have this problem connecting with my hosted API (with a valid SSL certificate from Let's Encrypt) on Android Level 21 (Android 5), 22 (Android 5.1), 23 (Android 6) and 24 (Android 7).

After trying both variant 1 and 2 without success, I gave up and removed support for these Android versions (represent like 5% of market share to this day).

No idea what's happening, the error doesn't help 😞

@raffaeler
Copy link
Author

@nelsonprsousa if the certificate on the API side is publicly verifiable, you should not have this issue at all.
My issue was about telling Android+React Native how to trust a private CA.

  1. double check that your cerificate is correctly deployed by browsing the API from a browser (I assume it is)
  2. verify the internal android error using adb logcat

@nelsonprsousa
Copy link

nelsonprsousa commented Jun 28, 2022

@nelsonprsousa if the certificate on the API side is publicly verifiable, you should not have this issue at all. My issue was about telling Android+React Native how to trust a private CA.

  1. double check that your cerificate is correctly deployed by browsing the API from a browser (I assume it is)
  2. verify the internal android error using adb logcat

Here's my API (checking on Desktop Chrome):
Screenshot 2022-06-28 at 13 04 39

I am assuming it is publicly verifiable.

However, on those Android versions (from API 22 to API 24), I have the "Network request failed" error.

I noticed that trying to directly open the website on Chrome on those old Android versions brings this error, it should be related:

Screenshot 2022-06-28 at 13 04 39

Certificate viewer:

So yeah, something weird on old Android version validating certificates?!

@raffaeler
Copy link
Author

@nelsonprsousa if this behavior happens only on older Android version, it is possible that the CA used by letsencrypt was not already available on those versions.
If you scroll in the mobile Chrome app, you should see some hint about the CA not being trusted or another error like that

@nelsonprsousa
Copy link

nelsonprsousa commented Jun 28, 2022

@nelsonprsousa if this behavior happens only on older Android version, it is possible that the CA used by letsencrypt was not already available on those versions. If you scroll in the mobile Chrome app, you should see some hint about the CA not being trusted or another error like that

yeap.. I was reading on Google and there are some problems with letsencrypt and old Android versions that I don't fully understood.

Do you think that the solution you gave of bundling the certificate will solve this problem (already tried without success), or it is something else and I just hijacked this discussion? 😅

@raffaeler
Copy link
Author

yeap.. I was reading on Google and there are some problems with letsencrypt and old Android versions that I don't fully understood.

Android ships a number of CAs that can only be updated with official security patches. If your CA was not shipped or updated at that time, of course it can't work.

Do you think that the solution you gave of bundling the certificate will solve this problem (already tried without success), or it is something else and I just hijacked this discussion? 😅

Bundling the certificate is a good solution whenever you need to use Android in an enterprise environment that works with a private CA.
In your case, you could try embedding the server certificate: exporting the CA (the one used by your letsencrypt certificate) from Windows in, converting with openssl, etc.. Not sure if it can work, it's not the scenario I described ad the beginning (and yes, you hijacked the thread 😅)

@nelsonprsousa
Copy link

yeap.. I was reading on Google and there are some problems with letsencrypt and old Android versions that I don't fully understood.

Android ships a number of CAs that can only be updated with official security patches. If your CA was not shipped or updated at that time, of course it can't work.

Do you think that the solution you gave of bundling the certificate will solve this problem (already tried without success), or it is something else and I just hijacked this discussion? 😅

Bundling the certificate is a good solution whenever you need to use Android in an enterprise environment that works with a private CA. In your case, you could try embedding the server certificate: exporting the CA (the one used by your letsencrypt certificate) from Windows in, converting with openssl, etc.. Not sure if it can work, it's not the scenario I described ad the beginning (and yes, you hijacked the thread 😅)

I'll try to find a solution for this specific problem elsewhere. Thank you for your support 🙏

@pedropankaj
Copy link

this work for me

@MuhammadAbdullah54321
Copy link

I am also facing same issue. my endpoint is https and not http. My other internet requests are working like those with Amplify

@raffaeler
Copy link
Author

@MuhammadAbdullah54321 this issue is strictly related to fetching with HTTPS where the server is using a private or self-signed certificate.
In this case, if you carefully follow my points you should resolve the issue.

It is very bad that meta is not even answering or even checking the issues. This should be clarified and be part of the official documentation.

@turjoy-real
Copy link

Check if your SSL is properly configured here.

@raffaeler
Copy link
Author

Check if your SSL is properly configured here.

This does not make any sense. The point of this entire thread is to use a non public CA as stated in the initial post, which is extremly common in any enterprise scenario.

The link you posted is a service that can only verify public websites. Also, I strongly reccomend to verify TLS (SSL does not exist anymore) using openssl utilities which are the most updated.

@CptKicks
Copy link

CptKicks commented Jan 2, 2023

@raffaeler
out of curiosity? What is your backend stack?

@raffaeler
Copy link
Author

The backend is ASP.NET Core but this doesn't make any difference. Any fetch on HTTPS involving a private CA would trigger the same issue.

@noalea
Copy link

noalea commented Jan 28, 2023

I realized I was using the http version of the endpoint so then I switched it to https and it worked.

@thahseen21
Copy link

The backend is ASP.NET Core but this doesn't make any difference. Any fetc

I'm too using .net core facing the same issue, did you find any solution for it ?

@raffaeler
Copy link
Author

I'm too using .net core facing the same issue, did you find any solution for it ?

Yes, I wrote "Resolved" in the title for a reason :-)
In the very first post I wrote the step-by-step to resolve this.

Anyway I am totally scared of Meta not taking in account the community about this. It's a real shame.

@ariccio
Copy link

ariccio commented Feb 13, 2023

Lemme just jump in that I'm always an advocate for bubbling as much error info up the stack as possible. There are those of us who go to great lengths, perhaps even cursed lengths, to make use of the info that is available from web fetch. It does actually make a big difference in debugging for those of us who go to these lengths, it's saved me untold hours of debugging, and its vastly more useful than the standard "failed to fetch" network error. If I had the time, and lacked the extreme disdain for Java, I'd write the patch myself!

@raffaeler
Copy link
Author

Lemme just jump in that I'm always an advocate for bubbling as much error info up the stack as possible. There are those of us who go to great lengths, perhaps even cursed lengths, to make use of the info that is available from web fetch. It does actually make a big difference in debugging for those of us who go to these lengths, it's saved me untold hours of debugging, and its vastly more useful than the standard "failed to fetch" network error. If I had the time, and lacked the extreme disdain for Java, I'd write the patch myself!

Exactly! And let me say that there is a huge difference between creating a library for internal or public use.
It looks like that some Meta developers are bullying the devs outside their company by not propagating the error as it should be in any good framework.

BTW this happens too often in many frameworks when you get errors like "file not found" without the name, etc. etc.

@GNUGradyn
Copy link

Still to this day, the error messages for fetch network errors are super super vague. Is this going to get fixed?

@xts-bit
Copy link

xts-bit commented Oct 2, 2023

@GNUGradyn You can use rn-fetch-blob fetch method instead of normal fetch

@GuillemGarciaDev
Copy link

POSIBLE SOLUTION

I faced the same problem (iOS working & Android failure) and in the end it turned out to be a problem because the domain to which the request was made contained an underscore (_) character. Removing the underscore by a dash solved the problem.

Previos domain
https://my_domain.com

Working domain
https://my-domain.com/

If you are using a domain other than localhost and use special characters it is possible that it may fail because of this. I will update my comment if I find any additional information.

I hope it helps 🙏🏻

@GreatGodson
Copy link

what do yo suggest for people using Expo, as there is no direct android folder of manifest file.

@raffaeler
Copy link
Author

@GreatGodson I'm not very familiar with Expo.
In my opinion it's better to avoid it because:

  • it does not provide full control over the framework and devices
  • when you need to move from Expo to the standard sdk, the migration requires too much effort.
    I understand that is attractive for the initial simplicity, but I don´t think that you can solve with Expo, out of avoiding custom certificates.

@dev-jwel
Copy link

dev-jwel commented Jan 7, 2024

Does your server contains full cert chain rather than only single certification?
This was a problem in my case.

@raffaeler
Copy link
Author

Does your server contains full cert chain rather than only single certification? This was a problem in my case.

@dev-jwel
Technically a server does not contain a chain. The just server uses a certificate emitted by either a CA or a SubCA.
In my case the server certificate was emitted by a SubCA, therefore I had to add the whole chain (CA+Sub) to the app. This is mandatory, otherwise the SubCA would not be trusted and the communication will fail anyway.

@csvan
Copy link

csvan commented Feb 17, 2024

It's simply sad that this catastrophic DX failure in RN has been around essentially since the beginning, yet there still is no clear roadmap for fixing it (or simply propagating the underlying errors to make it actually debuggable). It's barely even being acknowledged, yet is one of the most asked-about problems with RN.

Thanks a ton @raffaeler for doing God's work documenting issues like this, RN would more or less be dead without community members like you.

@AbrahamBrookes
Copy link

is there an alternative library we can use in place of fetch? Ie axios or just the plain xhr? Something that sidesteps this whole issue entirely?

@thecodemonster1
Copy link

thecodemonster1 commented May 10, 2024

I also have same problem (I am struggling so much for this🥺) any can help me please🙏,
I want to connect appropriate api to my Android/iOS app.

  • API is working fine (tested via postman)
  • when i hosted (localhost) a db.json on json-server it is working (then, there is no problems in my fetch code)

but when i run the application and when i input the details is showing this on console error: [TypeError: Network request failed]

I check the all the possible ways on the internet

this is the link of this issue in stackoverflow

@csvan
Copy link

csvan commented May 11, 2024

@thecodemonster1 try using the native logger (e.g. Logcat for Android) to capture more detailed information about why the call fails. The Metro console will not show you this.

JuanValeraDev added a commit to VictorGlvez/InfoCountriesReactNative that referenced this issue Jun 7, 2024
…rror TypeError: Network request failed e investigando por la red he visto una posible solución: facebook/react-native#32931
@NicolasD27
Copy link

for me, replacing localhost or my local ip with 10.0.2.2 worked

@raffaeler
Copy link
Author

@NicolasD27 do you realize that nobody can have any clue of what 10.0.2.2 represents in your network and that this issue should work regardless the IP assigned by the DHCP?

@billinghamj
Copy link

billinghamj commented Jul 17, 2024

Has anyone tried using XMLHttpRequest.setInterceptor or RCTNetworking.addListener('didCompleteNetworkResponse' to get access to the original error data? Obv not super ideal, but should work I think?

From what I can tell, all use of fetch in RN-land is done with whatwg-fetch, which ultimately ends up in the XMLHttpRequest implementation, which is here: https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Network/XMLHttpRequest.js

And the pertinent bits:

On e.g. iOS, the -[NSError localizedDescription] should be accessible via either route (though you will also need to figure out your request IDs)

I think this is the most detailed info available on the JS side of the bridge

@billinghamj
Copy link

billinghamj commented Jul 17, 2024

We ended up simplifying a bit by just patching react-native & whatwg-fetch to add a detail field to the errors. It doesn't change the error type or message, but the field should be visible to tools like Sentry, and will appear when serialized.

These are the patch files:

react-native+0.74.3.patch
whatwg-fetch+3.6.20.patch

We use patch-package to apply them

@fermellone
Copy link

fermellone commented Jul 23, 2024

Here is another solution.
adb reverse tcp:<your-server-port> tcp:<your-server-port>
It worked for me.

@asirialwis
Copy link

same issue here , when I replace ip address instead of the localhost, it works only for emulator. With the expo go , its not working.

@stesvis
Copy link

stesvis commented Nov 11, 2024

@raffaeler I am having this issue right now on Expo tho, is there a solution for the manages workflow?
it seems to happen only on apis that upload files.

@turjoy-real
Copy link

I faced this error due to the backend being http/1.1.

After the backend updated to http/2.x, the error was resolved.

@stesvis
Copy link

stesvis commented Nov 11, 2024

@raffaeler I am having this issue right now on Expo tho, is there a solution for the manages workflow? it seems to happen only on apis that upload files.

I figured out my own issue, i had to manually set the type: asset.mimeType because by default it was being mapped to asset.type, which was wrong.

        const formData = new FormData();
        formData.append("file", {
          type: asset.mimeType,
          uri: asset.uri,
          name: asset.fileName,
        } as any);

@hoaxvo16
Copy link

It has been 2 years, and this issue is still not resolved or explained. How crazy is that ?

@FreddyJohn
Copy link

FreddyJohn commented Nov 18, 2024

I am having this issue as well, RN please do your job, this request is perfectly fine and working in postman. Works fine on macOS on simulator, I have had an unbelievable amount of issues trying to build RN apps on windows, what's the deal?

@Kinqdos
Copy link

Kinqdos commented Nov 25, 2024

We ended up simplifying a bit by just patching react-native & whatwg-fetch to add a detail field to the errors. It doesn't change the error type or message, but the field should be visible to tools like Sentry, and will appear when serialized.

These are the patch files:

react-native+0.74.3.patch whatwg-fetch+3.6.20.patch

We use patch-package to apply them

Same problem here just the error no more details...
Thanks to this I was able to debug the problem

@Mikkelet
Copy link

Mikkelet commented Nov 27, 2024

Try opening the android folder in Android Studio and use its LogCat to read the error. In my case, the underlying error was Failed to send network request CDP event

@raffaeler
Copy link
Author

Try adding to your fetch header: "Accept-Encoding": "identity"

Could you please elaborate how this could help?

@Mikkelet
Copy link

Try adding to your fetch header: "Accept-Encoding": "identity"

Could you please elaborate how this could help?

I guess its anecdotal to the specific error. Ive removed that part from my answer. However, I did find the solution by debugging through Android Studio, which provides an actual JVM exception. I googled my exception and found the solution, which was the encoding header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 🌐Networking Related to a networking API.
Projects
None yet
Development

No branches or pull requests