Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps in FlatList #31602

Closed
lunaleaps opened this issue May 26, 2021 · 6 comments
Closed

Remove defaultProps in FlatList #31602

lunaleaps opened this issue May 26, 2021 · 6 comments
Assignees
@daschaa
Labels
Component: FlatList Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.

Comments

@lunaleaps
Copy link
Contributor

lunaleaps commented May 26, 2021 •
edited
Loading

See parent issue #31601

Expected Results

defaultProps are removed from FlatList
@lunaleaps lunaleaps mentioned this issue May 26, 2021
Closed
@lunaleaps lunaleaps added Component: FlatList Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript and removed Needs: Triage 🔍 labels May 26, 2021
@lunaleaps lunaleaps mentioned this issue May 26, 2021
Closed
6 tasks
@turker0 turker0 mentioned this issue May 27, 2021
Closed
@Fannolo
Copy link

Fannolo commented May 29, 2021

Hi can I also take this issue while I wait for #31607 to be merged? I saw that @oguzturker8 changed more than one file in his PR, please let me know if I can take it. Thanks!

@daschaa daschaa mentioned this issue Jul 1, 2021
Closed
@daschaa
Copy link
Contributor

daschaa commented Jul 1, 2021

If it is ok I would like to take over this issue.
I already submitted a pull-request.

@lunaleaps
Copy link
Contributor Author

Since I haven't seen a PR from @Fannolo, I'm good with this! @Fannolo please reply to this issue within the next 2 days if you're still interested in this issue or would like to pass it on. I will check in 2 days and if not I'll assign to @joxw1

Thanks everyone for your help!

@Fannolo
Copy link

Fannolo commented Jul 4, 2021

Hi @lunaleaps yes it's fine since @joxw1 already submitted a pr you can assign this task to him! Thank you!

@daschaa
Copy link
Contributor

daschaa commented Jul 4, 2021

Hi @lunaleaps yes it's fine since @joxw1 already submitted a pr you can assign this task to him! Thank you!

Thank you!

@lunaleaps lunaleaps assigned daschaa and unassigned Fannolo Jul 6, 2021
@lunaleaps lunaleaps linked a pull request Jul 14, 2021 that will close this issue
Remove defaultProps from FlatList #31798
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 20, 2021
@daschaa @facebook-github-bot
Remove defaultProps from FlatList (#31798)
7d5895d 
Summary:
Issue #31602. Remove `defaultProps` from `FlatList`.

## Changelog

[JavaScript] [Changed] - Remove defaultProps from FlatList

Pull Request resolved: #31798

Test Plan:
All test for `FlatList` pass.

https://user-images.githubusercontent.com/57131123/124164691-4066c980-daa1-11eb-8653-5c51640fe63e.mov

Reviewed By: charlesbdudley

Differential Revision: D29619867

Pulled By: lunaleaps

fbshipit-source-id: 8d8a6f095f80374407a55bac0b4e899bae04c577
@daschaa
Copy link
Contributor

daschaa commented Jul 22, 2021

@lunaleaps Can this be closed now? ☺️

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daschaa daschaa

Labels
Component: FlatList Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove defaultProps from FlatList
4 participants
@lunaleaps @Fannolo @react-native-bot @daschaa