Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useNativeDriver animation redraws inside animating Modal #21552

Closed
anshul-kai opened this issue Oct 7, 2018 · 17 comments
Closed

useNativeDriver animation redraws inside animating Modal #21552

anshul-kai opened this issue Oct 7, 2018 · 17 comments
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@anshul-kai
Copy link

anshul-kai commented Oct 7, 2018

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Memory: 2.55 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
Yarn: 1.5.1 - ~/.yarn/bin/yarn
npm: 6.0.1 - ~/.nvm/versions/node/v8.9.4/bin/npm
Watchman: 3.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 23.0.2, 23.0.3, 24.0.0, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.2, 27.0.3
API Levels: 23, 24, 25, 26, 27
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.2 => 0.57.2
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Description

Clone the below repository to notice the bug with native driver animations inside an animating Modal. Simply turn the switch to on and notice it reset to off when modal closes. Removing the animationType on the Modal component or disabling native driver fixes the problem.

Reproducible Demo

git clone https://[email protected]/akbn/custom-switch.git

@react-native-bot
Copy link
Collaborator

It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists.

The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running react-native info on a project using the latest release.

@anshul-kai anshul-kai changed the title useNativeDriver redraws upon unmount useNativeDriver animation redraws inside animating Modal Oct 9, 2018
@stale
Copy link

stale bot commented Jan 20, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 20, 2019
@anshul-kai
Copy link
Author

Yes, it's still an issue. I'm happy to provide more information if needed.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 20, 2019
@3luyka
Copy link

3luyka commented Jan 28, 2019

Will it be fixed?

@stale
Copy link

stale bot commented Aug 2, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 2, 2019
@anshul-kai
Copy link
Author

Yes, this is indeed still a problem on the latest version of the library.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 2, 2019
@mmazzarolo
Copy link

I guess this might be causing this react-native-modal issue

@didrikkvanvik
Copy link

Been an issue for over a year now. Is it going to be fixed? Is there any other solution than not using the native driver?

@anshul-kai
Copy link
Author

I've been using react-native for over 3 years. And although I love this framework, the underlying functionality is quite challenging to achieve given it supports multiple platforms. You either have to bite the bullet and write native code for corner cases or wait a long time for these issues to be addressed, simply because they aren't simple to fix.

Having said that, I'm hoping this gets some attention soon :)

@stale
Copy link

stale bot commented Jan 15, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 15, 2020
@anshul-kai
Copy link
Author

Yes, this is still an issue with the latest version of react-native 0.61.5. Thanks!

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 16, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 17, 2020
@anshul-kai
Copy link
Author

This still requires community attention!

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 17, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jul 18, 2020
@anshul-kai
Copy link
Author

Yes, this is still an issue.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jul 18, 2020
facebook-github-bot pushed a commit that referenced this issue May 25, 2021
Summary:
This sync includes the following changes:
- **[459c34fde](facebook/react@459c34fde )**: Add flag concurrent root ([#21552](facebook/react#21552)) //<Samuel Susla>//

Changelog:
[General][Changed] - React Native sync for revisions 3169430...459c34f

jest_e2e[run_all_tests]

Reviewed By: mdvacca

Differential Revision: D28641463

fbshipit-source-id: 0930a8f82e49b222582995e4c8b2c8a41564bf53
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 4, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@facebook facebook locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants