[0.54] [iOS] Selection jumps to end of TextInput on every change

[larskarbo]

On version 0.54.2 on iOS

When typing in a TextInput with a controlled value prop, multiple onSelectionChange events fires.

You don't always see the flickering when rendering, but this can cause problems if you have a very long TextInput or use the selection prop in other ways.

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 9.8.0
Yarn: 1.5.1
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.2 => 0.54.2

Expected Behavior

One onSelectionChange event is fired and cursor doesn't jump to end and back.

Actual Behavior

For every keystroke there is one instant correct event, then the new value goes through setState and renders down into the value prop again. This causes two more events: one where selection is at end of the string, followed by one correct event.

Steps to Reproduce

The code I used to test is in this snack: https://snack.expo.io/HJaZucVYf

Use that code with v0.54.2 to reproduce

[maxlxq]

me too

[akalin-keybase]

I think this happens only for multiline TextInputs.

[vrgimael]

This seems to be causing other glitches, especially regarding how auto-correct detects changes.

It only happens on multiline indeed.

Any updates on the issue?

[vrgimael]

Update - this solved my problems:

ff70ecf#diff-a5239f085f0beab82ba2c1643be157ac

[matthieubessol]

I am also getting this. I'm on react-native v0.55.4. When I hit return two times and returning back to my previous text, letters are capitalized every time. Your code did fix the problem, but it would be nice if they fix it.

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

[akalin-keybase]

this is still broken, afaik

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

[akalin-keybase]

this is still broken, afaik

[thymikee]

Closing, because there's no recent activity under the issue.

@akalin-keybase if it still doesn't work for you, please create a new issue with a minimal reproduction we can investigate.

[jeffreybrowning]

If #18341 (comment) did fix, this remains an issue for Expo users as SDK 33 uses react-native 0.59

[mistikk]

Same issue on rn 0.61.2, please reopen to this issue @thymikee @jeffreybrowning

[nguyen95]

Me too, this happened on ios, rn 0.61.3

[jeffreybrowning]

I unfortunately do not have the power to reopen. Only commenting for 👀