You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RCTImageStoreManager and RCTBlobManager both have a priority of 0.
I sat debugging in XCode and printed the following list of handlers and their corresponding priorities in the function handlerForRequest in RCTNetworking.mm
I am assuming the priority should be given to the ImageStoreManager over the BlobManager.
This further implies that ImageLoader's Priority should be higher.
When I went and manually changed the priorities, it seemed to not crash, but not sure if this is the right fix.
This issue had been faced by others in the closed issue: 9031 #9031 (comment)
For more context, I was using HTMLView from the react-native-htmlview npm package https://www.npmjs.com/package/react-native-htmlview
and happens when I load html fetched from a server, which contains an image tag with this source. I'm not sure if this issue is specific to HTMLView but seems more like a ReactNative issue, so posting here. Let me know if you think otherwise, or need more information
The text was updated successfully, but these errors were encountered:
tsjamm
added a commit
to tsjamm/react-native
that referenced
this issue
Oct 1, 2017
Summary: RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities.
Summary:
RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities.
Issue: #16159Closes#16160
Differential Revision: D6017931
Pulled By: shergin
fbshipit-source-id: 91f2737af4f2f97197734b696105e1cdc5683365
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.
stalebot
added
the
Stale
There has been a lack of activity on this issue and it may be closed soon.
label
Nov 30, 2017
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 6.11.2
Yarn: Not Found
npm: 3.10.10
Watchman: 4.6.0
Xcode: Xcode 9.0 Build version 9A235
Android Studio: 2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.4 => 0.48.4
Target Platform: iOS (11)
Issue
RCTImageStoreManager and RCTBlobManager both have a priority of 0.
I sat debugging in XCode and printed the following list of handlers and their corresponding priorities in the function
handlerForRequest
inRCTNetworking.mm
I am assuming the priority should be given to the ImageStoreManager over the BlobManager.
This further implies that ImageLoader's Priority should be higher.
When I went and manually changed the priorities, it seemed to not crash, but not sure if this is the right fix.
This issue had been faced by others in the closed issue: 9031
#9031 (comment)
For more context, I was using
HTMLView
from thereact-native-htmlview
npm packagehttps://www.npmjs.com/package/react-native-htmlview
and happens when I load html fetched from a server, which contains an image tag with this source. I'm not sure if this issue is specific to
HTMLView
but seems more like a ReactNative issue, so posting here. Let me know if you think otherwise, or need more informationThe text was updated successfully, but these errors were encountered: