Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation template is not working anymore #14313

Closed
dunhuang opened this issue Jun 3, 2017 · 2 comments
Closed

navigation template is not working anymore #14313

dunhuang opened this issue Jun 3, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@dunhuang
Copy link

dunhuang commented Jun 3, 2017

App generated by cli 'react-native init --template navigation' is not working anymore. The template should be upgraded.
@hramos
Copy link
Contributor

hramos commented Jun 3, 2017

This hasn't fully launched just yet. When you use a template name, it will look for a npm package named react-native-template-XXXX where XXXX is the template name. I don't see a react-native-template-navigation template in the npm registry.

@hramos hramos closed this as completed Jun 3, 2017
@hramos
Copy link
Contributor

hramos commented Jun 8, 2017

Turns out this particular template is not loaded from npm, but rather is bundled in the react-native package itself. The template can be found at https://github.com/facebook/react-native/tree/master/local-cli/templates

What specifically is not working for you?

agrcrobles added a commit to agrcrobles/react-native that referenced this issue Jun 13, 2017
@agrcrobles
Fixed navigation template facebook#14313
6ed3906
@agrcrobles agrcrobles mentioned this issue Jun 13, 2017
Closed
1 task
agrcrobles added a commit to agrcrobles/react-native that referenced this issue Sep 12, 2017
@agrcrobles @agarciarobles
Fixed navigation template facebook#14313
ac5c59d
facebook-github-bot pushed a commit that referenced this issue Oct 12, 2017
@agrcrobles @facebook-github-bot
Fixed navigation template
224d294 
Summary:
- [x] Explain the **motivation** for making this change.

It fixes #14313
Closes #14495

Differential Revision: D6042094

Pulled By: hramos

fbshipit-source-id: d70e42bfee0a22882bad91cb885fb0cfc91c7d38
@facebook facebook locked as resolved and limited conversation to collaborators Jun 3, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed navigation template agrcrobles/react-native
3 participants
@hramos @dunhuang @react-native-bot