-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not documented AdSupportIOS #12623
Comments
Can you elaborate? |
Sure. In order to get AdSupportIOS to work, I had to manually add files to Xcode. I feel like this wasn't clear that it was required to somehow manually link files, as the documentation about AdSupportIOS currently says nothing about this: https://facebook.github.io/react-native/docs/adsupportios.html. |
Would you be willing to open a PR to add the necessary steps missing from that file? Otherwise, can you comment on this issue with the exact list of steps you had to take in order to use AdSupportIOS. |
I can open a PR. Where's the best place/file to do that? |
You would need to add comments to the source file at https://github.com/facebook/react-native/blob/master/Libraries/AdSupport/AdSupportIOS.js. You can take a look at other APIs to see how these comments should be formatted. |
Is there anything else that I need to do here, or is the PR all set?
…On Wed, Mar 1, 2017 at 6:16 PM, Héctor Ramos ***@***.***> wrote:
You would need to add comments to the source file at
https://github.com/facebook/react-native/blob/master/Libraries/AdSupport/
AdSupportIOS.js. You can take a look at other APIs to see how these
comments should be formatted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12623 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFQ8oDSuE3g6Db4jFkqNoy8vtsw-Ut8bks5rhfxagaJpZM4MOxWF>
.
|
Summary: Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread #1303). So this includes the instructions to manually add RCTAdSupport files from node_modules. See: #12623 Closes #12657 Differential Revision: D4962321 Pulled By: hramos fbshipit-source-id: ed9aed3b4c16e72d1f9557f5c16fcdadfdd743ea
Summary: Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread facebook#1303). So this includes the instructions to manually add RCTAdSupport files from node_modules. See: facebook#12623 Closes facebook#12657 Differential Revision: D4962321 Pulled By: hramos fbshipit-source-id: ed9aed3b4c16e72d1f9557f5c16fcdadfdd743ea
Description
I had to add the RCTAdSupport.h and RCTAdSupport.m files to XCode to manually link to react native in order to get AdSupportIOS to stop throwing "undefined is not an object.... ". There ought to be better documentation for this.
The text was updated successfully, but these errors were encountered: