Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can i do a POST request? #1188

Closed
EricKwong opened this issue May 7, 2015 · 2 comments
Closed

How can i do a POST request? #1188

EricKwong opened this issue May 7, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@EricKwong
Copy link

How can I do a post request?
@EricKwong EricKwong changed the title How do i do a POST request? How can i do a POST request? May 7, 2015
@MossP
Copy link

MossP commented Jun 4, 2015

Care to share your solution?

@MossP
Copy link

MossP commented Jun 4, 2015

For anyone else, it looks like this is the solution. The fetch function was taken straight from here.
https://github.com/github/fetch

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
leotm pushed a commit that referenced this issue Dec 16, 2022
@intergalacticspacehighway @facebook-github-bot
fix: remove gap if its last element in line (fix flex gap extra spaci…
d867ec0 
…ng when children determine parents main axis size) (#1188)

Summary:
Fixes - #35553

## Approach
We're using `betweenMainDim` to add [gap between](https://github.com/intergalacticspacehighway/yoga/blob/bbeede82d36cd89657faf385aaa704f45443c326/yoga/Yoga.cpp#L2495) items in main axis. This is resulting in increased [main axis](https://github.com/intergalacticspacehighway/yoga/blob/bbeede82d36cd89657faf385aaa704f45443c326/yoga/Yoga.cpp#L2598) dimension of the container as it gets added even for the last element. One solution is to keep using it and subtract the gap when last element is reached.

## Aside
Mutating this value feels weird, but I think `betweenMainDim` gets initialized for every line so should be fine? I did some manual tests to verify. I tried running tests but I'll have to downgrade the java version. Let me know if anything fails. Thanks! 🙏

X-link: facebook/yoga#1188

Reviewed By: necolas

Differential Revision: D42078162

Pulled By: NickGerleman

fbshipit-source-id: 0e535618350422e001141a8786a83fc81651afe9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EricKwong @MossP @react-native-bot