Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ListView crashes when updateClippedSubviews triggers RCTImageView.cancelImageLoad #10473

Closed
seph14 opened this issue Oct 20, 2016 · 4 comments
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@seph14
Copy link

seph14 commented Oct 20, 2016

Issue Description

I have a ListView of small cells of products, when I pulled very fast to trigger the load more, there's a chance it crashes. It is especially frequent on slower devices: iPhone5 / iPhone6plus.
If setting removeClippedSubviews to be false, it appears solve the problem.

Steps to Reproduce / Code Snippets

simulator screen shot 2016 oct 20 15 14 51
This is the list view. Sorry the full code seem to be a bit long but since I can reproduce this on several different listviews, this shouldn't be an special case.

And this is the stack trace from Xcode:
stacktrace

Looks like is rooted from the clipping process.

Expected Results

Shouldn't crash

Additional Information

  • React Native version: 0.35
  • Platform(s):iOS
  • Operating System:OSX
@SunnyGurnani
Copy link
Contributor

This is similar #10433

@SunnyGurnani
Copy link
Contributor

@seph14 I tried setting removeClippedSubviews={false} but that didnt stopped the crashes.

@seph14
Copy link
Author

seph14 commented Oct 21, 2016

@SunnyGurnani I think the clipping action removes those invisible images which finally lead to the crash. You are right its a temporary hack and doesn't fix the root.

MattFoley pushed a commit to skillz/react-native that referenced this issue Jan 5, 2017
@shergin shergin added the Platform: iOS iOS applications. label Mar 16, 2017
@hramos
Copy link
Contributor

hramos commented Mar 31, 2017

Closing as ListView is deprecated in 0.43. Use FlatList.

@hramos hramos closed this as completed Mar 31, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants