Skip to content

Commit

Permalink
remove unnecessary public methods on RCTFabricSurface
Browse files Browse the repository at this point in the history
Summary:
Changelog: [Internal]

`start` and `stop` are already part of `RCTSurfaceProtocol` which is a public protocol conformance, we don't need to add these to this header, it's just extra work for the compiler

Reviewed By: RSNara

Differential Revision: D31776005

fbshipit-source-id: d89ad4dbe35e1b67cfa750c6414c40f9b4fc7f24
  • Loading branch information
philIip authored and facebook-github-bot committed Oct 20, 2021
1 parent c7d0c94 commit f1aabc5
Showing 1 changed file with 9 additions and 21 deletions.
30 changes: 9 additions & 21 deletions React/Fabric/Surface/RCTFabricSurface.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ NS_ASSUME_NONNULL_BEGIN
moduleName:(NSString *)moduleName
initialProperties:(NSDictionary *)initialProperties;

#pragma mark - Surface presenter

/**
* EXPERIMENTAL
* Reset's the Surface to it's initial stage.
* It uses the passed in surface presenter, and whatever else was passed in init.
*/
- (void)resetWithSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter;

#pragma mark - Dealing with UIView representation, the Main thread only access

/**
Expand All @@ -54,27 +63,6 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (RCTSurfaceView *)view;

#pragma mark - Start & Stop

/**
* Starts or stops the Surface.
* A Surface object can be stopped and then restarted.
* The starting process includes initializing all underlying React Native
* infrastructure and running React app.
* Surface stops itself on deallocation automatically.
* Returns YES in case of success. Returns NO if the Surface is already
* started or stopped.
*/
- (BOOL)start;
- (BOOL)stop;

/**
* EXPERIMENTAL
* Reset's the Surface to it's initial stage.
* It uses the passed in surface presenter, and whatever else was passed in init.
*/
- (void)resetWithSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter;

#pragma mark - Layout: Setting the size constrains

/**
Expand Down

0 comments on commit f1aabc5

Please sign in to comment.