-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BREAKING: metro: rename 'unbundle' to 'ram bundle'
Summary: @public Let's get rid of the "unbundle" terminology and instead use "RAM bundle", short for "Random Access Bundle" format. THIS IS A BREAKING CHANGE FOR OSS, as the command becomes `ram-bundle` instead of `unbundle`. It realy shouldn't be a command to start with (only a "format" specifier for the `bundle` command), but I don't want to do that change at this point. Reviewed By: davidaurelio Differential Revision: D8894433 fbshipit-source-id: 5565f9ae94c7c2d7f6b25f95ae45b64f27f6aec8
- Loading branch information
1 parent
583cb13
commit ebf5aea
Showing
3 changed files
with
45 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @format | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const bundleWithOutput = require('./bundle').withOutput; | ||
const bundleCommandLineArgs = require('./bundleCommandLineArgs'); | ||
const outputUnbundle = require('metro/src/shared/output/unbundle'); | ||
|
||
/** | ||
* Builds the bundle starting to look for dependencies at the given entry path. | ||
*/ | ||
function ramBundle(argv, config, args) { | ||
return bundleWithOutput(argv, config, args, outputUnbundle); | ||
} | ||
|
||
module.exports = { | ||
name: 'ram-bundle', | ||
description: | ||
'builds javascript as a "Random Access Module" bundle for offline use', | ||
func: ramBundle, | ||
options: bundleCommandLineArgs.concat({ | ||
command: '--indexed-ram-bundle', | ||
description: | ||
'Force the "Indexed RAM" bundle file format, even when building for android', | ||
default: false, | ||
}), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,25 +9,22 @@ | |
|
||
'use strict'; | ||
|
||
const bundleWithOutput = require('./bundle').withOutput; | ||
const bundleCommandLineArgs = require('./bundleCommandLineArgs'); | ||
const outputUnbundle = require('metro/src/shared/output/unbundle'); | ||
|
||
/** | ||
* Builds the bundle starting to look for dependencies at the given entry path. | ||
*/ | ||
function unbundle(argv, config, args) { | ||
return bundleWithOutput(argv, config, args, outputUnbundle); | ||
} | ||
|
||
module.exports = { | ||
name: 'unbundle', | ||
description: 'builds javascript as "unbundle" for offline use', | ||
func: unbundle, | ||
description: 'Deprecated. Renamed to `ram-bundle`.', | ||
func: () => { | ||
throw new Error( | ||
'The `unbundle` command has been renamed `ram-bundle` to better ' + | ||
'represent the actual functionality. `ram` mean "Random Access ' + | ||
'Module", this particular format of bundle. Functionality remained ' + | ||
'unchanged.', | ||
); | ||
}, | ||
options: bundleCommandLineArgs.concat({ | ||
command: '--indexed-unbundle', | ||
description: | ||
'Force indexed unbundle file format, even when building for android', | ||
description: 'Deprecated. Renamed to `--indexed-ram-bundle`.', | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
jeanlauliac
|
||
default: false, | ||
}), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure I understand this - how's that renamed to a flag if the function is throwing an error in all the cases?