Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix onPress event for nested Text in RN Android
Summary: This bug is caused by RNAndroid dispatching an incorrect sequence of events to JS when the user taps on a Text. Taking into consideration the example P462662009, when the user taps of the "Inner" text, RN Android is dispatching three events: topTouchStart, topTouchStart and topTouchEnd. The information stored on the first two JS events is correct, but the problem is that it is duplicated. This sequence of events makes Pressability to dispatch the event to the incorrect target. This was originally introduced in D3035589 (39fdce2) (2016) In this diff I'm changing the way RN Android bubbles events when the user taps on a ReactTextView. From now on, events won't be bubbled anymore, and they will be handled by the ReactRootView.onInterceptTouchEvent: https://fburl.com/code/rbt8$ Additionally, I'm creating a FeatureFlag in case this change has a unknown side effect that's only detected in production. I will create a MC for FB4A in the next diffs of the stack changelog: [Fixed][Android] Fix onPress event for nested Text in RN Android Reviewed By: javache Differential Revision: D31628461 fbshipit-source-id: 177397d4369191a3c97e2f86e801757b27ee5121
- Loading branch information