Make testID work for iOS tabs

Reviewed By: shergin Differential Revision: D6455054 fbshipit-source-id: 3c667b585e9332a1dbfff1fd3325f2c95985a5be
facebook · Dec 4, 2017 · e19d9de · e19d9de
1 parent ca10604
commit e19d9de
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/React/Views/RCTTabBarItem.h b/React/Views/RCTTabBarItem.h
@@ -28,6 +28,7 @@
 @property (nonatomic, assign, getter=isSelected) BOOL selected;
 @property (nonatomic, readonly) UITabBarItem *barItem;
 @property (nonatomic, copy) RCTBubblingEventBlock onPress;
+@property (nonatomic, strong) NSString *testID;
 
 #if TARGET_OS_TV
 @property (nonatomic, assign) BOOL wasSelectedInJS;

diff --git a/React/Views/RCTTabBarItem.m b/React/Views/RCTTabBarItem.m
@@ -58,6 +58,11 @@ - (UITabBarItem *)barItem
   return _barItem;
 }
 
+- (void)setTestID:(NSString *)testID
+{
+  self.barItem.accessibilityIdentifier = testID;
+}
+
 - (void)setBadge:(id)badge
 {
   _badge = [badge copy];

diff --git a/React/Views/RCTTabBarItemManager.m b/React/Views/RCTTabBarItemManager.m
@@ -30,6 +30,7 @@ - (UIView *)view
 RCT_EXPORT_VIEW_PROPERTY(onPress, RCTBubblingEventBlock)
 RCT_EXPORT_VIEW_PROPERTY(badgeColor, UIColor)
 RCT_EXPORT_VIEW_PROPERTY(isTVSelectable, BOOL)
+RCT_EXPORT_VIEW_PROPERTY(testID, NSString)
 RCT_CUSTOM_VIEW_PROPERTY(title, NSString, RCTTabBarItem)
 {
   view.barItem.title = json ? [RCTConvert NSString:json] : defaultView.barItem.title;