-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix crash when move on the edge of some phones like HUAWEI P9
Summary: The app crashes because of `TouchEventCoalescingKeyHelper.getCoalescingKey` throwing an exception when move on the edge of some phones like HUAWEI P9. It's caused by that the down time differs from `ACTION_DOWN` to `ACTION_MOVE` which belongs to the same gesture when I touched on the edge of my HUAWEI P9. It seems a native bug of manufacturer. Related issue #11302. ``` java.lang.RuntimeException: Tried to get non-existent cookie at com.facebook.react.uimanager.events.TouchEventCoalescingKeyHelper.getCoalescingKey(TouchEventCoalescingKeyHelper.java:75) at com.facebook.react.uimanager.events.TouchEvent.init(TouchEvent.java:93) at com.facebook.react.uimanager.events.TouchEvent.obtain(TouchEvent.java:46) at com.facebook.react.uimanager.JSTouchDispatcher.handleTouchEvent(JSTouchDispatcher.java:118) at com.facebook.react.ReactRootView.dispatchJSTouchEvent(ReactRootView.java:158) at com.facebook.react.ReactRootView.onInterceptTouchEvent(ReactRootView.java:130) at android.view.Vie Closes #12063 Differential Revision: D4779060 Pulled By: astreet fbshipit-source-id: 5cf20084ff9081f2535ff9cb3b99d1d52c443f03
- Loading branch information
1 parent
3b28644
commit d2939ea
Showing
2 changed files
with
23 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters